Skip to content

Commit

Permalink
Add #393 to changelogs
Browse files Browse the repository at this point in the history
  • Loading branch information
@KronicDeth
KronicDeth committed Aug 28, 2016
1 parent 82a5702 commit a044398
Show file tree
Hide file tree
Showing 2 changed files with 53 additions and 19 deletions.
45 changes: 26 additions & 19 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,81 +5,82 @@
- [Changelog](#changelog)
- [v4.3.0](#v430)
- [Enhancements](#enhancements)
- [Bug Fixes](#bug-fixes)
- [v4.2.0](#v420)
- [Enhancements](#enhancements-1)
- [Bug Fixes](#bug-fixes)
- [Bug Fixes](#bug-fixes-1)
- [v4.1.0](#v410)
- [Enhancements](#enhancements-2)
- [Bug Fixes](#bug-fixes-1)
- [Bug Fixes](#bug-fixes-2)
- [v4.0.0](#v400)
- [Enhancements](#enhancements-3)
- [Bug Fixes](#bug-fixes-2)
- [Bug Fixes](#bug-fixes-3)
- [Incompatible Changes](#incompatible-changes)
- [v3.0.1](#v301)
- [Bug Fixes](#bug-fixes-3)
- [Bug Fixes](#bug-fixes-4)
- [v3.0.0](#v300)
- [Enhancements](#enhancements-4)
- [Bug Fixes](#bug-fixes-4)
- [Bug Fixes](#bug-fixes-5)
- [Incompatible Changes](#incompatible-changes-1)
- [v2.2.0](#v220)
- [Enhancement](#enhancement)
- [Bug Fixes](#bug-fixes-5)
- [Bug Fixes](#bug-fixes-6)
- [v2.1.0](#v210)
- [Enhancement](#enhancement-1)
- [Bug Fixes](#bug-fixes-6)
- [Bug Fixes](#bug-fixes-7)
- [v2.0.0](#v200)
- [Enhancements](#enhancements-5)
- [Bug Fixes](#bug-fixes-7)
- [Bug Fixes](#bug-fixes-8)
- [Incompatible Changes](#incompatible-changes-2)
- [v1.2.1](#v121)
- [Enhancements](#enhancements-6)
- [Bug Fixes](#bug-fixes-8)
- [Bug Fixes](#bug-fixes-9)
- [v1.2.0](#v120)
- [Enhancements](#enhancements-7)
- [Bug Fixes](#bug-fixes-9)
- [Bug Fixes](#bug-fixes-10)
- [v1.1.0](#v110)
- [Enhancements](#enhancements-8)
- [v1.0.0](#v100)
- [Enhancements](#enhancements-9)
- [Bug Fixes](#bug-fixes-10)
- [Bug Fixes](#bug-fixes-11)
- [Incompatible Fixes](#incompatible-fixes)
- [v0.3.5](#v035)
- [Enhancements](#enhancements-10)
- [Bug Fixes](#bug-fixes-11)
- [Bug Fixes](#bug-fixes-12)
- [v0.3.4](#v034)
- [Enhancements](#enhancements-11)
- [v0.3.3](#v033)
- [Enhancements](#enhancements-12)
- [v0.3.2](#v032)
- [Bug Fixes](#bug-fixes-12)
- [Bug Fixes](#bug-fixes-13)
- [v0.3.1](#v031)
- [Enhancements](#enhancements-13)
- [v0.3.0](#v030)
- [Enhancements](#enhancements-14)
- [Incompatible Changes](#incompatible-changes-3)
- [v0.2.1](#v021)
- [Enhancements](#enhancements-15)
- [Bug Fixes](#bug-fixes-13)
- [Bug Fixes](#bug-fixes-14)
- [v0.2.0](#v020)
- [Enhancements](#enhancements-16)
- [Incompatible Changes](#incompatible-changes-4)
- [v0.1.4](#v014)
- [Enhancements](#enhancements-17)
- [Bug Fixes](#bug-fixes-14)
- [v0.1.3](#v013)
- [Bug Fixes](#bug-fixes-15)
- [v0.1.3](#v013)
- [Bug Fixes](#bug-fixes-16)
- [v0.1.2](#v012)
- [Enhancements](#enhancements-18)
- [v0.1.1](#v011)
- [Bug Fixes](#bug-fixes-16)
- [Bug Fixes](#bug-fixes-17)
- [v0.1.0](#v010)
- [Enhancements](#enhancements-19)
- [Bug Fixes](#bug-fixes-17)
- [Bug Fixes](#bug-fixes-18)
- [v0.0.3](#v003)
- [Enhancements](#enhancements-20)
- [v0.0.2](#v002)
- [Enhancements](#enhancements-21)
- [Bug Fixes](#bug-fixes-18)
- [Bug Fixes](#bug-fixes-19)

<!-- END doctoc generated TOC please keep comment here to allow auto update -->

Expand All @@ -101,6 +102,12 @@
* From in-file aliases
* `__MODULE__`
* In project modules (using index already used for Go To Declaration)
* [#393](https://github.com/KronicDeth/intellij-elixir/pull/393) - In addition to `StubBased#canonicalName`, there now also `StubBased#canonicalNames`, for when a call defines multiple canonical names, as is the case for `defimpl <PROTOCOL>, for: [<TYPE>, ...]`. - [@KronicDeth](https://github.com/KronicDeth)

### Bug Fixes
* [#393](https://github.com/KronicDeth/intellij-elixir/pull/393) - [@KronicDeth](https://github.com/KronicDeth)
* `defimpl <PROTOCOL>, for: [<TYPE>, ...]` generates multiple canonical names, which are stored in the stub index.
* When retrieved from the `AllName` index, the `defimpl`'s Implementation will render as if only the `defimpl <PROTOCOL>, for: <TYPE>` was used for the `<TYPE>` matching the lookup name in the Goto Symbol dialog. For example, if you search for `Tuple`, `JSX.Encoder.Tuple` will match for [`defimpl JSX.Encoder, for: for: [Tuple, PID, Port, Reference, Function, Any]`](https://github.com/talentdeficit/exjsx/blob/master/lib/jsx.ex#L152-L155).

## v4.2.0

Expand Down
27 changes: 27 additions & 0 deletions src/META-INF/plugin.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,33 @@
<li>In project modules (using index already used for Go To Declaration)</li>
</ul>
</li>
<li>
In addition to <code>StubBased#canonicalName</code>, there now also <code>StubBased#canonicalNames</code>,
for when a call defines multiple canonical names, as is the case for
<code>defimpl &lt;PROTOCOL&gt;, for: [&lt;TYPE&gt;, ...]</code>.
</li>
</ul>
</li>
<li>
<p>Bug Fixes</p>
<ul>
<li>
<p>
<code>defimpl &lt;PROTOCOL&gt;, for: [&lt;TYPE&gt;, ...]</code> generates multiple canonical names,
which are stored in the stub index.
</p>
<ul>
<li>
When retrieved from the <code>AllName</code> index, the <code>defimpl</code>'s Implementation will
render as if only the <code>defimpl &lt;PROTOCOL&gt;, for: &lt;TYPE&gt;</code> was used for the
<code>&lt;TYPE&gt;</code> matching the lookup name in the Goto Symbol dialog. For example, if you
search for <code>Tuple</code>, <code>JSX.Encoder.Tuple</code> will match for
<a href="https://github.com/talentdeficit/exjsx/blob/master/lib/jsx.ex#L152-L155">
<code>defimpl JSX.Encoder, for: for: [Tuple, PID, Port, Reference, Function, Any]</code>
</a>.
</li>
</ul>
</li>
</ul>
</li>
</ul>
Expand Down

0 comments on commit a044398

Please sign in to comment.