Always have a FindUsagesProvider#getType #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All function name elements act as PsiNameIdentifiers now even if they don't resolve, but that means they all need to support FindUsagesProvider#getType, which they don't, so use a placeholder of "unknown call type" for any Call that can't be matched and "unkown element" for anything else.
KronicDeth
added a commit
that referenced
this pull request
Mar 31, 2016
KronicDeth
added a commit
that referenced
this pull request
Mar 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #277
Changelog
PsiNameIdentifiers now even if they don't resolve, but that means they all need to supportFindUsagesProvider#getType, which they don't, so use a placeholder of "unknown call type" for anyCallthat can't be matched and "unknown element" for anything else.