Land #283, Always have a FindUsagesProvider#getType

KronicDeth · Mar 31, 2016 · bba9f5a · bba9f5a
2 parents d48302b + 7228a82
commit bba9f5a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/org/elixir_lang/FindUsagesProvider.java b/src/org/elixir_lang/FindUsagesProvider.java
@@ -90,8 +90,7 @@ public String getHelpId(@NotNull PsiElement psiElement) {
     @NotNull
     @Override
     public String getType(@NotNull final PsiElement element) {
-        // Intentionally use `null` to trigger `@NotNull` when a new element type is passed.
-        String type = null;
+        String type = "unknown element type";
 
         if (element instanceof Call) {
             Call call = (Call) element;
@@ -126,6 +125,8 @@ public String getType(@NotNull final PsiElement element) {
                 type = "use";
             } else if (element instanceof AtUnqualifiedNoParenthesesCall) {
                 type = "module attribute";
+            } else {
+                type = "unknown call type";
             }
         } else if (element instanceof MaybeModuleName) {
             MaybeModuleName maybeModuleName = (MaybeModuleName) element;
@@ -135,7 +136,6 @@ public String getType(@NotNull final PsiElement element) {
             }
         }
 
-        //noinspection ConstantConditions
         return type;
     }