Mean statistics fixes #1091
Merged
Mean statistics fixes #1091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gator, such that mixed numbers are unified first. Big number support is dropped. Created generic rowX() function aggregateOfRow(), used by rowMean() and rowMeanOf<T>()
AndreiKingsley
approved these changes
Mar 17, 2025
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/DataColumnType.kt
Show resolved
Hide resolved
# Conflicts: # core/api/core.api
…lue. This simplifies logic in a lot of places. It can still be nullable for aggregators that require it (like min/max).
Collaborator
Author
|
Fixed feedback, but I also found some other important stuff:
|
unifying numbers can now handle null/nothing in the input.
Jolanrensen
requested review from
AndreiKingsley
and removed request for
AndreiKingsley
…s of aggregateOf. Fixed nullability in lambda return types. Made sure all lambdas are crossinline. Added test for medianOf to check everything still works as expected.
AndreiKingsley
approved these changes
Mar 18, 2025
Collaborator
AndreiKingsley
left a comment
AndreiKingsley
left a comment
There was a problem hiding this comment.
Great! However, I wonder - are there any aggregators that take null into account?
Collaborator
Author
They all filter nulls out before aggregating. This was always done already for columns and it's now always the case. There doesn't seem to be a statistic function that does something special with nulls, so I think this is the best choice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps and follows #961
To be merged after #1078mean. It's now based onTwoStepNumbersAggregator, such that mixed numbers are unified first.rowX()functionaggregateOfRow(), used byrowMean()androwMeanOf<T>()describe()