Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(konnect): KongTarget reconciler #627

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Sep 20, 2024

What this PR does / why we need it:
Add KongTarget reconciler to reconcile KongTargets.
Which issue this PR fixes

Major part of #576

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@randmonkey randmonkey added this to the KGO v1.4.x milestone Sep 20, 2024
@randmonkey randmonkey self-assigned this Sep 20, 2024
@randmonkey randmonkey force-pushed the feat/kong_target_reconciler branch 5 times, most recently from 12e3487 to bafaf00 Compare September 23, 2024 07:35
@randmonkey randmonkey marked this pull request as ready for review September 23, 2024 07:35
@randmonkey randmonkey requested a review from a team as a code owner September 23, 2024 07:35
controller/konnect/reconciler_upstreamref.go Outdated Show resolved Hide resolved
controller/konnect/reconciler_upstreamref_test.go Outdated Show resolved Hide resolved
controller/konnect/reconciler_upstreamref.go Outdated Show resolved Hide resolved
controller/konnect/reconciler_upstreamref.go Outdated Show resolved Hide resolved
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid 👍

Please add a sample manifest in config/samples/ for Upstream with Target so that users know how this can be used (and also so that it's tested via:

samples:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Setup go
uses: actions/setup-go@v5
with:
go-version-file: go.mod
- name: Create k8s KinD Cluster
uses: helm/kind-action@v1.10.0
- uses: jdx/mise-action@v2
with:
install: false
# We use install.all to install all CRDs and resources also the ones that are not bundled
# in base kustomization (e.g. currently AIGateway) but which have samples defined.
- name: Verify installing CRDs via kustomize works
run: make install.all
- name: Install and delete each sample one by one
run: make test.samples
- name: Verify that uninstalling operator CRDs via kustomize works
run: make uninstall.all
)

controller/konnect/reconciler_generic.go Outdated Show resolved Hide resolved
@pmalek
Copy link
Member

pmalek commented Sep 23, 2024

When rebasing please use the functions to set programmed condition on entities introduced in #633.

@randmonkey
Copy link
Contributor Author

When rebasing please use the functions to set programmed condition on entities introduced in #633.

Done and added sample KongTarget.

@randmonkey randmonkey merged commit ee21458 into main Sep 24, 2024
21 checks passed
@randmonkey randmonkey deleted the feat/kong_target_reconciler branch September 24, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants