feat(konnect): KongTarget reconciler (#627)

* Add KongTarget reconciler

* fix apiauth ref and add unit tests

* add assertions for updated entity

* add KongTarget sample and do not delete when upstream being deleted

.mockery.yaml

@@ -18,6 +18,7 @@ packages:
       ConsumerGroupSDK:
       PluginSDK:
       UpstreamsSDK:
+      TargetsSDK:
       MeSDK:
       KongCredentialBasicAuthSDK:
       CACertificatesSDK:

CHANGELOG.md

@@ -58,6 +58,8 @@
   [#516](https://github.com/Kong/gateway-operator/pull/516)
 - Add `KongPluginBinding` reconciler for Konnect Plugins.
   [#513](https://github.com/Kong/gateway-operator/pull/513), [#535](https://github.com/Kong/gateway-operator/pull/535)
+- Add `KongTarget` reconciler for Konnect Targets.
+  [#627](https://github.com/Kong/gateway-operator/pull/627)
 - The `DataPlaneKonnectExtension` CRD has been introduced. Such a CRD can be attached
   to a `DataPlane` via the extensions field to have a konnect-flavored `DataPlane`.
   [#453](https://github.com/Kong/gateway-operator/pull/453), [#578](https://github.com/Kong/gateway-operator/pull/578)

config/rbac/role/role.yaml

@@ -155,6 +155,7 @@ rules:
   - kongplugins/status
   - kongroutes/status
   - kongservices/status
+  - kongtargets/status
   - kongupstreampolicies/status
   - kongupstreams/status
   - kongvaults/status
@@ -182,6 +183,7 @@ rules:
   resources:
   - kongroutes
   - kongservices
+  - kongtargets
   - kongupstreams
   verbs:
   - get

config/samples/konnect_kongtarget.yaml

@@ -0,0 +1,46 @@
+kind: KonnectAPIAuthConfiguration
+apiVersion: konnect.konghq.com/v1alpha1
+metadata:
+  name: konnect-api-auth-dev-1
+  namespace: default
+spec:
+  type: token
+  token: kpat_XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
+  serverURL: us.api.konghq.com
+---
+kind: KonnectGatewayControlPlane
+apiVersion: konnect.konghq.com/v1alpha1
+metadata:
+  name: test1
+  namespace: default
+spec:
+  name: test1
+  labels:
+    app: test1
+    key1: test1
+  konnect:
+    authRef:
+      name: konnect-api-auth-dev-1
+---
+kind: KongUpstream
+apiVersion: configuration.konghq.com/v1alpha1
+metadata:
+  name: upstream-1
+  namespace: default
+spec:
+  name: upstream-1
+  controlPlaneRef:
+    type: konnectNamespacedRef
+    konnectNamespacedRef:
+      name: test1
+---
+kind: KongTarget
+apiVersion: configuration.konghq.com/v1alpha1
+metadata:
+  name: target-1
+  namespace: default
+spec:
+  upstreamRef:
+    name: upstream-1
+  target: "10.0.0.1"
+  weight: 100

controller/konnect/conditions/conditions.go

@@ -114,3 +114,17 @@ const (
 	// condition type indicating that one or more KongConsumerGroup references are invalid.
 	KongConsumerGroupRefsReasonInvalid = "Invalid"
 )
+
+const (
+	// KongUpstreamRefValidConditionType is the type of the condition that indicates
+	// whether the KongUpstream reference is valid and points to an existing
+	// KongUpstreamRefValid.
+	KongUpstreamRefValidConditionType = "KongUpstreamRefValid"
+
+	// KongUpstreamRefReasonValid is the reason used with the KongUpstreamRefValid
+	// condition type indicating that the KongUpstream reference is valid.
+	KongUpstreamRefReasonValid = "Valid"
+	// KongUpstreamRefReasonInvalid is the reason used with the KongUpstreamRefValid
+	// condition type indicating that the KongUpstream reference is invalid.
+	KongUpstreamRefReasonInvalid = "Invalid"
+)

controller/konnect/constraints/constraints.go

@@ -21,7 +21,9 @@ type SupportedKonnectEntityType interface {
 		configurationv1alpha1.KongPluginBinding |
 		configurationv1alpha1.KongCredentialBasicAuth |
 		configurationv1alpha1.KongUpstream |
-		configurationv1alpha1.KongCACertificate
+		configurationv1alpha1.KongCACertificate |
+		configurationv1alpha1.KongTarget
+
 	// TODO: add other types
 
 	GetTypeName() string

controller/konnect/errors.go

@@ -61,3 +61,28 @@ type ReferencedKongConsumerDoesNotExist struct {
 func (e ReferencedKongConsumerDoesNotExist) Error() string {
 	return fmt.Sprintf("referenced Kong Consumer %s does not exist: %v", e.Reference, e.Err)
 }
+
+// ReferencedKongUpstreamIsBeingDeleted is an error type that is returned when
+// a Konnect entity references a Kong Upstream which is being deleted.
+type ReferencedKongUpstreamIsBeingDeleted struct {
+	Reference         types.NamespacedName
+	DeletionTimestamp time.Time
+}
+
+// Error implements the error interface.
+func (e ReferencedKongUpstreamIsBeingDeleted) Error() string {
+	return fmt.Sprintf("referenced Kong Upstream %s is being deleted (deletion timestamp: %s)",
+		e.Reference, e.DeletionTimestamp)
+}
+
+// ReferencedKongUpstreamDoesNotExist is an error type that is returned when
+// a Konnect entity references a Kong Upstream which does not exist.
+type ReferencedKongUpstreamDoesNotExist struct {
+	Reference types.NamespacedName
+	Err       error
+}
+
+// Error implements the error interface.
+func (e ReferencedKongUpstreamDoesNotExist) Error() string {
+	return fmt.Sprintf("referenced Kong Upstream %s does not exist: %v", e.Reference, e.Err)
+}

controller/konnect/ops/kongtarget.go

@@ -0,0 +1,14 @@
+package ops
+
+import (
+	"context"
+
+	sdkkonnectops "github.com/Kong/sdk-konnect-go/models/operations"
+)
+
+// TargetsSDK is the interface for the Konnect Taret SDK.
+type TargetsSDK interface {
+	CreateTargetWithUpstream(ctx context.Context, req sdkkonnectops.CreateTargetWithUpstreamRequest, opts ...sdkkonnectops.Option) (*sdkkonnectops.CreateTargetWithUpstreamResponse, error)
+	UpsertTargetWithUpstream(ctx context.Context, req sdkkonnectops.UpsertTargetWithUpstreamRequest, opts ...sdkkonnectops.Option) (*sdkkonnectops.UpsertTargetWithUpstreamResponse, error)
+	DeleteTargetWithUpstream(ctx context.Context, req sdkkonnectops.DeleteTargetWithUpstreamRequest, opts ...sdkkonnectops.Option) (*sdkkonnectops.DeleteTargetWithUpstreamResponse, error)
+}