Skip to content

DNM: Test Ksai #7520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Guaris wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DNM: Test Ksai #7520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions app/_ksai-test/no-copy-code-test.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
# KSAI test file: output blocks

@kong-ksai kong-ksai Bot Oct 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃煚 Medium bug

The page has no front matter. tools/frontmatter-validator/index.js globs app/**/*.md, ignores no app/_ksai-test path, and base.json requires content_type, so the validate-frontmatters check fails at this head. Add app/_ksai-test/** to the validator ignore list, or delete the page before merge.

React 馃憤 if this finding helped, 馃憥 if it did not.


Temporary file to check that the "Output blocks" review rule runs. Do not merge. The `_ksai-test` directory is not a Jekyll collection, so it isn't published.

## Violation

The following block shows only command output, so it should end with `{:.no-copy-code}`. It doesn't, so KSAI should flag it.

```sh
HTTP/1.1 200 OK
Content-Type: application/json
Connection: keep-alive

{"message": "pong"}
```

@kong-ksai kong-ksai Bot Oct 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃數 Low bug

The block at lines 9 to 15 holds only a response, so the Output blocks rule requires {:.no-copy-code} directly after the closing fence. The marker is missing. No page renders this block today: the file has no front matter and _ksai-test is not a Jekyll collection. Add the marker to satisfy the rule.

Suggested change
```
```
{:.no-copy-code}

React 馃憤 if this finding helped, 馃憥 if it did not.


## Control: command

The following block is a command the reader runs, so KSAI should not flag it.

```sh
curl -i http://localhost:8000/ping
```

## Control: marked output

The following output block is marked correctly, so KSAI should not flag it.

```sh
HTTP/1.1 200 OK
```
{:.no-copy-code}

## Control: marked output with an extra class

The following output block has `.no-copy-code` plus another class, so KSAI should not flag it.

```sh
HTTP/1.1 200 OK
Content-Type: application/json
```
{:.no-copy-code .collapsible}
Loading