Repository navigation
DNM: Test Ksai - #7520
DNM: Test Ksai#7520Guaris wants to merge 1 commit into
Conversation
✅ Deploy Preview for kongdeveloper ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
✅ KSAI Review: Finished Run report (federated) · 1 paid run · $0.1358 total
Reviewing cost $0.1358 |
![kong-ksai[bot]](https://avatars.githubusercontent.com/in/4495376?s=60&v=4){kind=small}
There was a problem hiding this comment.
| Check | Result |
|---|---|
| Scope | Adds one temporary test page, app/_ksai-test/no-copy-code-test.md, holding four fenced command or output blocks. |
| Mandate | default-code-reviewer |
| Findings | 1 Medium, 1 Low |
| Findings audit | Independent audit completed: kept both findings, verified the validator glob against the failed check, and restated the output-block finding at Low without its unpublished-page impact claim. |
The change adds one temporary test page and nothing else. The page is a fixture for the Output blocks rule, and the rule fires on the unmarked block. The file also fails front-matter validation, so a required check is red at this head.
No additional concerns found.
| @@ -0,0 +1,42 @@ | |||
| # KSAI test file: output blocks | |||
There was a problem hiding this comment.
🟠 Medium bug
The page has no front matter. tools/frontmatter-validator/index.js globs app/**/*.md, ignores no app/_ksai-test path, and base.json requires content_type, so the validate-frontmatters check fails at this head. Add app/_ksai-test/** to the validator ignore list, or delete the page before merge.
React 👍 if this finding helped, 👎 if it did not.
| Connection: keep-alive | ||
|
|
||
| {"message": "pong"} | ||
| ``` |
There was a problem hiding this comment.
🔵 Low bug
The block at lines 9 to 15 holds only a response, so the Output blocks rule requires {:.no-copy-code} directly after the closing fence. The marker is missing. No page renders this block today: the file has no front matter and _ksai-test is not a Jekyll collection. Add the marker to satisfy the rule.
| ``` | |
| ``` | |
| {:.no-copy-code} |
React 👍 if this finding helped, 👎 if it did not.
1 participant
No description provided.