Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #54

Merged
merged 43 commits into from
Nov 6, 2023
Merged

Dev #54

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
b53078a
Updated module name, might be reverted for a future pull-request to t…
yigithanbalci Jan 17, 2023
da0001b
Merge pull request #1 from yigithanbalci/dev
yigithanbalci Jan 17, 2023
6645855
Updated go.mod
yigithanbalci Jan 17, 2023
262485a
Merge pull request #2 from yigithanbalci/dev
yigithanbalci Jan 17, 2023
653f376
Create go.yml
yigithanbalci Jan 17, 2023
b722dce
Delete ci.yml
yigithanbalci Jan 17, 2023
7f0a9af
Added challenges endpoint
yigithanbalci Mar 4, 2023
1b234b5
Added valorant endpoints
yigithanbalci Mar 5, 2023
e24ed36
Merge pull request #3 from yigithanbalci/master
yigithanbalci Jul 7, 2023
69197ed
Changed repository name to the original
yigithanbalci Jul 7, 2023
afabe75
Merge pull request #4 from yigithanbalci/master
yigithanbalci Jul 9, 2023
5b8c302
Revert "Changed repository name to the original"
yigithanbalci Jul 9, 2023
de0e6a2
Fixed PR review requests
yigithanbalci Aug 4, 2023
104feee
Merge remote-tracking branch 'origin/dev' into dev
yigithanbalci Aug 4, 2023
1ed61d4
Merge branch 'master' into dev
yigithanbalci Aug 4, 2023
b404563
Renamed go.yml to make it compatible with base repository
yigithanbalci Aug 5, 2023
73eeac3
Merge remote-tracking branch 'origin/dev' into dev
yigithanbalci Aug 5, 2023
18d8ab2
Fix wrong tests
yigithanbalci Oct 26, 2023
8dd4a54
Fix lint issues regarding comments
yigithanbalci Oct 26, 2023
2634436
Fix naming in README.md
yigithanbalci Oct 26, 2023
0bfa155
Merge remote-tracking branch 'upstream/master' into dev
yigithanbalci Oct 26, 2023
8ba8074
Fix linting issues
yigithanbalci Oct 27, 2023
5ef131a
Merge branch 'dev' of https://github.com/yigithanbalci/golio into lin…
yigithanbalci Oct 27, 2023
af1b733
Merged changes from dev
yigithanbalci Oct 27, 2023
14b4037
Merge pull request #5 from yigithanbalci/linting-fixes
yigithanbalci Oct 27, 2023
c01ec0e
Update README.md
yigithanbalci Oct 27, 2023
32f7047
lintin fixes
yigithanbalci Oct 27, 2023
a186474
goimports re-run
yigithanbalci Oct 27, 2023
c56d5c3
lint fix again.
yigithanbalci Oct 27, 2023
3b31079
lint fix again.
yigithanbalci Oct 27, 2023
6be1533
lint fix again.
yigithanbalci Oct 27, 2023
e5366ab
lint fix again.
yigithanbalci Oct 27, 2023
7cfe3d5
Add codecov config
yigithanbalci Oct 27, 2023
11d3425
changed test cases for coverage
yigithanbalci Oct 27, 2023
1548505
Merge pull request #6 from yigithanbalci/yigithanbalci-patch-1
yigithanbalci Oct 27, 2023
f472590
fix: Fix linting & test problems, run gofmt & goimports on all files
yigithanbalci Oct 29, 2023
9c61135
fix: Fix PR review issues
yigithanbalci Oct 30, 2023
f09ee09
fix: lint long lines
yigithanbalci Oct 30, 2023
2fb9d2f
fix: lint long lines for endpointChallengesLeaderboards
yigithanbalci Oct 30, 2023
bea373b
fix: endpointChallengesLeaderboards split into two variables because …
yigithanbalci Oct 30, 2023
7183e3d
fix: Add client test
yigithanbalci Oct 31, 2023
08d6dca
fix: linting issue in new client test for val
yigithanbalci Oct 31, 2023
a880405
fix: run goimports
yigithanbalci Oct 31, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Changed repository name to the original"
This reverts commit 69197ed.
  • Loading branch information
yigithanbalci committed Jul 9, 2023
commit 5b8c3029f57251e22b62b1bc5682a869ef24472a
2 changes: 1 addition & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ linters-settings:
goimports:
# put imports beginning with prefix after 3rd-party packages;
# it's a comma-separated list of prefixes
local-prefixes: github.com/KnutZuidema/golio
local-prefixes: github.com/yigithanbalci/golio
gocyclo:
# minimal code complexity to report, 30 by default (but we recommend 10-20)
min-complexity: 10
Expand Down
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[![Documentation](https://godoc.org/github.com/KnutZuidema/golio?status.svg)](https://godoc.org/github.com/KnutZuidema/golio)
![CI](https://github.com/KnutZuidema/golio/workflows/CI/badge.svg?branch=master)
[![Go Report Card](https://goreportcard.com/badge/github.com/KnutZuidema/golio)](https://goreportcard.com/report/github.com/KnutZuidema/golio)
[![codecov](https://codecov.io/gh/KnutZuidema/golio/branch/master/graph/badge.svg)](https://codecov.io/gh/KnutZuidema/golio)
[![Documentation](https://godoc.org/github.com/yigithanbalci/golio?status.svg)](https://godoc.org/github.com/yigithanbalci/golio)
![CI](https://github.com/yigithanbalci/golio/workflows/CI/badge.svg?branch=master)
[![Go Report Card](https://goreportcard.com/badge/github.com/yigithanbalci/golio)](https://goreportcard.com/report/github.com/yigithanbalci/golio)
[![codecov](https://codecov.io/gh/yigithanbalci/golio/branch/master/graph/badge.svg)](https://codecov.io/gh/yigithanbalci/golio)
KnutZuidema marked this conversation as resolved.
Show resolved Hide resolved

# Golio

Expand All @@ -18,8 +18,8 @@ import (
"fmt"
"net/http"

"github.com/KnutZuidema/golio"
"github.com/KnutZuidema/golio/api"
"github.com/yigithanbalci/golio"
"github.com/yigithanbalci/golio/api"
log "github.com/sirupsen/logrus"
)

Expand Down
4 changes: 2 additions & 2 deletions datadragon/data_dragon.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import (

log "github.com/sirupsen/logrus"

"github.com/KnutZuidema/golio/api"
"github.com/KnutZuidema/golio/internal"
"github.com/yigithanbalci/golio/api"
"github.com/yigithanbalci/golio/internal"
)

const (
Expand Down
6 changes: 3 additions & 3 deletions datadragon/data_dragon_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"github.com/KnutZuidema/golio/api"
"github.com/KnutZuidema/golio/internal"
"github.com/KnutZuidema/golio/internal/mock"
"github.com/yigithanbalci/golio/api"
"github.com/yigithanbalci/golio/internal"
"github.com/yigithanbalci/golio/internal/mock"
)

func TestNewClient(t *testing.T) {
Expand Down
4 changes: 2 additions & 2 deletions datadragon/model_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import (
log "github.com/sirupsen/logrus"
"github.com/stretchr/testify/assert"

"github.com/KnutZuidema/golio/api"
"github.com/KnutZuidema/golio/internal"
"github.com/yigithanbalci/golio/api"
"github.com/yigithanbalci/golio/internal"
)

func TestChampionData_GetExtended(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module github.com/KnutZuidema/golio
module github.com/yigithanbalci/golio

go 1.19

Expand Down
10 changes: 5 additions & 5 deletions golio.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ import (

log "github.com/sirupsen/logrus"

"github.com/KnutZuidema/golio/api"
"github.com/KnutZuidema/golio/datadragon"
"github.com/KnutZuidema/golio/internal"
"github.com/KnutZuidema/golio/riot"
"github.com/KnutZuidema/golio/static"
"github.com/yigithanbalci/golio/api"
"github.com/yigithanbalci/golio/datadragon"
"github.com/yigithanbalci/golio/internal"
"github.com/yigithanbalci/golio/riot"
"github.com/yigithanbalci/golio/static"
)

// Client is a client for both the Riot API and the Data Dragon service
Expand Down
2 changes: 1 addition & 1 deletion golio_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
log "github.com/sirupsen/logrus"
"github.com/stretchr/testify/require"

"github.com/KnutZuidema/golio/api"
"github.com/yigithanbalci/golio/api"
)

func TestNewClient(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion internal/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (

log "github.com/sirupsen/logrus"

"github.com/KnutZuidema/golio/api"
"github.com/yigithanbalci/golio/api"
)

const (
Expand Down
4 changes: 2 additions & 2 deletions internal/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import (
"github.com/sirupsen/logrus"
"github.com/stretchr/testify/assert"

"github.com/KnutZuidema/golio/api"
"github.com/KnutZuidema/golio/internal/mock"
"github.com/yigithanbalci/golio/api"
"github.com/yigithanbalci/golio/internal/mock"
)

func TestClient_DoRequest(t *testing.T) {
Expand Down
8 changes: 4 additions & 4 deletions riot/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ package riot
import (
log "github.com/sirupsen/logrus"

"github.com/KnutZuidema/golio/api"
"github.com/KnutZuidema/golio/internal"
"github.com/KnutZuidema/golio/riot/lol"
"github.com/KnutZuidema/golio/riot/lor"
"github.com/yigithanbalci/golio/api"
"github.com/yigithanbalci/golio/internal"
"github.com/yigithanbalci/golio/riot/lol"
"github.com/yigithanbalci/golio/riot/lor"
)

// Client provides access to all Riot API endpoints
Expand Down
2 changes: 1 addition & 1 deletion riot/lol/champion.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package lol
import (
log "github.com/sirupsen/logrus"

"github.com/KnutZuidema/golio/internal"
"github.com/yigithanbalci/golio/internal"
)

// ChampionClient provides methods for the champions endpoints of the League of Legends API.
Expand Down
2 changes: 1 addition & 1 deletion riot/lol/champion_mastery.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (

log "github.com/sirupsen/logrus"

"github.com/KnutZuidema/golio/internal"
"github.com/yigithanbalci/golio/internal"
)

// ChampionMasteryClient provides methods for the champion mastery endpoints of the
Expand Down
6 changes: 3 additions & 3 deletions riot/lol/champion_mastery_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"github.com/KnutZuidema/golio/api"
"github.com/KnutZuidema/golio/internal"
"github.com/KnutZuidema/golio/internal/mock"
"github.com/yigithanbalci/golio/api"
"github.com/yigithanbalci/golio/internal"
"github.com/yigithanbalci/golio/internal/mock"
)

func TestChampionMasteryClient_List(t *testing.T) {
Expand Down
6 changes: 3 additions & 3 deletions riot/lol/champion_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"github.com/KnutZuidema/golio/api"
"github.com/KnutZuidema/golio/internal"
"github.com/KnutZuidema/golio/internal/mock"
"github.com/yigithanbalci/golio/api"
"github.com/yigithanbalci/golio/internal"
"github.com/yigithanbalci/golio/internal/mock"
)

func TestChampionClient_GetFreeRotation(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion riot/lol/client.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package lol

import "github.com/KnutZuidema/golio/internal"
import "github.com/yigithanbalci/golio/internal"

// Client pools all methods for endpoints of the League of Legends API.
type Client struct {
Expand Down
2 changes: 1 addition & 1 deletion riot/lol/league.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (

log "github.com/sirupsen/logrus"

"github.com/KnutZuidema/golio/internal"
"github.com/yigithanbalci/golio/internal"
)

// LeagueClient provides methods for league endpoints of the League of Legends API.
Expand Down
6 changes: 3 additions & 3 deletions riot/lol/league_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"github.com/KnutZuidema/golio/api"
"github.com/KnutZuidema/golio/internal"
"github.com/KnutZuidema/golio/internal/mock"
"github.com/yigithanbalci/golio/api"
"github.com/yigithanbalci/golio/internal"
"github.com/yigithanbalci/golio/internal/mock"
)

func TestLeagueClient_GetChallenger(t *testing.T) {
Expand Down
4 changes: 2 additions & 2 deletions riot/lol/match.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import (

log "github.com/sirupsen/logrus"

"github.com/KnutZuidema/golio/api"
"github.com/KnutZuidema/golio/internal"
"github.com/yigithanbalci/golio/api"
"github.com/yigithanbalci/golio/internal"
)

// MatchClient provides methods for the match endpoints of the League of Legends API.
Expand Down
6 changes: 3 additions & 3 deletions riot/lol/match_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"github.com/KnutZuidema/golio/api"
"github.com/KnutZuidema/golio/internal"
"github.com/KnutZuidema/golio/internal/mock"
"github.com/yigithanbalci/golio/api"
"github.com/yigithanbalci/golio/internal"
"github.com/yigithanbalci/golio/internal/mock"
)

func TestMatchClient_List(t *testing.T) {
Expand Down
4 changes: 2 additions & 2 deletions riot/lol/model.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import (
"strconv"
"strings"

"github.com/KnutZuidema/golio/datadragon"
"github.com/KnutZuidema/golio/static"
"github.com/yigithanbalci/golio/datadragon"
"github.com/yigithanbalci/golio/static"
)

// ChampionInfo contains information about the free champion rotation
Expand Down
10 changes: 5 additions & 5 deletions riot/lol/model_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"github.com/KnutZuidema/golio/api"
"github.com/KnutZuidema/golio/datadragon"
"github.com/KnutZuidema/golio/internal"
"github.com/KnutZuidema/golio/internal/mock"
"github.com/KnutZuidema/golio/static"
"github.com/yigithanbalci/golio/api"
"github.com/yigithanbalci/golio/datadragon"
"github.com/yigithanbalci/golio/internal"
"github.com/yigithanbalci/golio/internal/mock"
"github.com/yigithanbalci/golio/static"
)

func TestLeagueList_GetRank(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion riot/lol/spectator.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (

log "github.com/sirupsen/logrus"

"github.com/KnutZuidema/golio/internal"
"github.com/yigithanbalci/golio/internal"
)

// SpectatorClient provides methods for the spectator endpoints of the League of Legends API.
Expand Down
6 changes: 3 additions & 3 deletions riot/lol/spectator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"github.com/KnutZuidema/golio/api"
"github.com/KnutZuidema/golio/internal"
"github.com/KnutZuidema/golio/internal/mock"
"github.com/yigithanbalci/golio/api"
"github.com/yigithanbalci/golio/internal"
"github.com/yigithanbalci/golio/internal/mock"
)

func TestSpectatorClient_ListFeatured(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion riot/lol/status.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package lol
import (
log "github.com/sirupsen/logrus"

"github.com/KnutZuidema/golio/internal"
"github.com/yigithanbalci/golio/internal"
)

// StatusClient provides methods for the status endpoints of the League of Legends API.
Expand Down
6 changes: 3 additions & 3 deletions riot/lol/status_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"github.com/KnutZuidema/golio/api"
"github.com/KnutZuidema/golio/internal"
"github.com/KnutZuidema/golio/internal/mock"
"github.com/yigithanbalci/golio/api"
"github.com/yigithanbalci/golio/internal"
"github.com/yigithanbalci/golio/internal/mock"
)

func TestStatusClient_Get(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion riot/lol/summoner.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (

log "github.com/sirupsen/logrus"

"github.com/KnutZuidema/golio/internal"
"github.com/yigithanbalci/golio/internal"
)

// SummonerClient provides methods for the summoner endpoints of the League of Legends API.
Expand Down
6 changes: 3 additions & 3 deletions riot/lol/summoner_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import (
"github.com/sirupsen/logrus"
"github.com/stretchr/testify/assert"

"github.com/KnutZuidema/golio/api"
"github.com/KnutZuidema/golio/internal"
"github.com/KnutZuidema/golio/internal/mock"
"github.com/yigithanbalci/golio/api"
"github.com/yigithanbalci/golio/internal"
"github.com/yigithanbalci/golio/internal/mock"
)

func TestSummonerClient_GetByName(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion riot/lol/third_party_code.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (

log "github.com/sirupsen/logrus"

"github.com/KnutZuidema/golio/internal"
"github.com/yigithanbalci/golio/internal"
)

// ThirdPartyCodeClient provides methods for the third party code endpoints of the
Expand Down
6 changes: 3 additions & 3 deletions riot/lol/third_party_code_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"github.com/KnutZuidema/golio/api"
"github.com/KnutZuidema/golio/internal"
"github.com/KnutZuidema/golio/internal/mock"
"github.com/yigithanbalci/golio/api"
"github.com/yigithanbalci/golio/internal"
"github.com/yigithanbalci/golio/internal/mock"
)

func TestThirdPartyCodeClient_Get(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion riot/lol/tournament.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (

log "github.com/sirupsen/logrus"

"github.com/KnutZuidema/golio/internal"
"github.com/yigithanbalci/golio/internal"
)

// TournamentClient provides methods for the tournament endpoints of the League of Legends API.
Expand Down
6 changes: 3 additions & 3 deletions riot/lol/tournament_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"github.com/KnutZuidema/golio/api"
"github.com/KnutZuidema/golio/internal"
"github.com/KnutZuidema/golio/internal/mock"
"github.com/yigithanbalci/golio/api"
"github.com/yigithanbalci/golio/internal"
"github.com/yigithanbalci/golio/internal/mock"
)

func TestTournamentClient_CreateCodes(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion riot/lor/client.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package lor

import "github.com/KnutZuidema/golio/internal"
import "github.com/yigithanbalci/golio/internal"

// Client pools methods for the Legends of Runeterra API.
type Client struct {
Expand Down
6 changes: 3 additions & 3 deletions riot/lor/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import (

"github.com/sirupsen/logrus"

"github.com/KnutZuidema/golio/api"
"github.com/KnutZuidema/golio/internal"
"github.com/KnutZuidema/golio/internal/mock"
"github.com/yigithanbalci/golio/api"
"github.com/yigithanbalci/golio/internal"
"github.com/yigithanbalci/golio/internal/mock"
)

func TestNewClient(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion riot/lor/ranked.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package lor

import "github.com/KnutZuidema/golio/internal"
import "github.com/yigithanbalci/golio/internal"

// RankedClient provides methods for the ranked endpoints of the Legends of Runeterra API.
type RankedClient struct {
Expand Down
Loading