Dev #54
Merged
Dev #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he original repository
Updated module name, might be reverted for a future pull-request to the original repository
Updated go.mod
merge new endpoints
Changed repository name to the original
This reverts commit 69197ed.
KnutZuidema
reviewed
Jul 10, 2023
|
I have updated it according to your review. But I couldn't figure out why the pipeline is lingering. |
KnutZuidema
reviewed
Oct 19, 2023
# Conflicts: # riot/lol/constants.go
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 21 27 +6
Lines 817 955 +138
==========================================
+ Hits 817 955 +138
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ting-fixes # Conflicts: # README.md # riot/client.go
Linting fixes
Update README.md
|
Not all linting problems were showing at once, therefore I have run CI in my forked branch and merged changes to my dev branch which was the merging branch for this PR. I guess this time it should pass all controls in the pipeline |
KnutZuidema
reviewed
Oct 30, 2023
KnutZuidema
reviewed
Oct 31, 2023
| } | ||
|
|
||
| // NewClient returns a new instance of a League of Legends client. | ||
| func NewClient(base *internal.Client) *Client { |
There was a problem hiding this comment.
this constructor is not covered by the test suite. add a test for this constructor.
|
Thanks a ton @yigithanbalci for your work. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issues: