Restructure Cypress e2e tests #2790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses a RESOURCE_LOCK to ensure that only one runs at a time
josephsnyder
approved these changes
Apr 9, 2025
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
LGTM! If CI passes, we'll merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
|
I suspect that this PR makes the |
Collaborator
Author
|
The tests passed with no failures multiple times, and I'm confident that I found the |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 23, 2025
Implicit dependencies between Cypress tests weren't caught in #2790. This PR resolves the issues by forcing Cypress tests for test-related pages to run after the `remove-build` test which operates on the same data. This should fix the Cypress flakiness in CI we've observed over the course of the last few weeks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the work in #2698, moving Cypress-specific CTest content to dedicated files. Additionally, I improved the dependency structure, leading to faster CI runs. I plan to make a follow-up PR to further improve the dependency structure.