Reorganize CMake/CTest scripts #2698
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test can take up to 30 seconds in CI
josephsnyder
approved these changes
Feb 4, 2025
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
No issues with local CTest or CI invocations. Looks good to me!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
|
It looks like the merge queue jobs failed due to issues with some of the Cypress tests I moved around. I'll take a look locally. |
This was referenced Apr 5, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 7, 2025
This PR contains a subset of the changes in #2698 for clarity. Spec and Cypress component test definitions have been moved to dedicated files instead of the top-level `CMakeLists.txt`. In addition to moving logic around, this PR re-introduces the forgotten `data-table` Cypress component test and allows Cypress component tests to run in parallel with other tests, utilizing a resource lock to ensure two Cypress component tests never run at the same time.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 7, 2025
The `autoremovebuilds` test is completely broken, and is not hooked up to anything in our test infrastructure. Given that the functionality it tests has been superseded by newer logic, this test is no longer relevant. This PR pulls out these specific changes from the broader changes in #2698 to reduce the number of different changes in #2698.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 14, 2025
This PR continues the work in #2698, moving Cypress-specific CTest content to dedicated files. Additionally, I improved the dependency structure, leading to faster CI runs. I plan to make a follow-up PR to further improve the dependency structure.
Collaborator
Author
|
All of the important parts of this PR have now been split into separate PRs, and #2808 cleans up the rest. This PR is now obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the work in #2664, this PR removes some of the bottlenecks slowing down the test suite on developer machines by running long tests concurrently where possible. This PR also adds the ability to run Cypress tests concurrently and reorganizes some of the messy test generation helper functions. While it would be nice to run all of the Cypress tests concurrently, Cypress is resource intensive and experiments only showed a marginal improvement in running times.
On my developer machine, these changes reduced the running time for the full test suite from 9 minutes to 8.5 minutes. Although the CI runners are substantially less powerful than my machine, I expect at least a small reduction in CI job times.