Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added the 3D model for Seiko MS621F #486

Merged
merged 3 commits into from
Jan 28, 2019

Conversation

Misca1234
Copy link
Collaborator

@Misca1234 Misca1234 commented Dec 26, 2018

When created the 3D model for battery holder Seiko MS621F
https://www.sii.co.jp/en/me/files/2014/02/file_EXTENDED_PRDCT_SPEC_75_FILE_11.jpg

It seems that the battery circles was off 0.4, earlier origo was at -4.6 but should be 5.0

Foot print push
KiCad/kicad-footprints#1218

3D model push
#486

3D model script push
easyw/kicad-3d-models-in-freecad#245

bild

bild

bild


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items as you complete them:

  • A screenshot of the model(s) aligned with KiCad footprints is very useful
  • Was the 3D model(s) created in a mechanical modelling program?
  • Source files (or scripts) have been contributed
  • Step model submitted in 1:1 scale
  • WRL model submitted in 1:2.54 scale
  • 3D model alignment checked against KiCad footprint
  • WRL model uses correct material properties
  • Geometry check performed against mechanical models

@myfreescalewebpage myfreescalewebpage added Addition Adds new package 3D to library Pending reviewer A pull request waiting for a reviewer labels Jan 7, 2019
@Shackmeister Shackmeister added the Pending footprint Pending footprint acceptance before merging label Jan 19, 2019
@Shackmeister Shackmeister removed the Pending footprint Pending footprint acceptance before merging label Jan 28, 2019
@Shackmeister
Copy link
Collaborator

looks great :)
Not really sure if this should be considered a Battery rather than a Batteryholder, but that might be for another day :)

@Shackmeister Shackmeister merged commit e7a229f into KiCad:master Jan 28, 2019
@Misca1234
Copy link
Collaborator Author

Thanks, yes, there is always some examples that does not fit

@Misca1234 Misca1234 deleted the Seiko_MS621F branch January 29, 2019 16:13
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Mar 5, 2019
DaToBSn pushed a commit to DaToBSn/kicad-packages3D that referenced this pull request Jul 2, 2019
* 'master' of github.com:KiCad/kicad-packages3D:
  Added the 3D model for Seiko MS621F (KiCad#486)
  removed source to fix issue KiCad#521
  Varistor: Add a new model
  TO-SOT SMD: Add 3D models for On Semiconductor ECH8 package
  Recreated all models using union
  correct material export, additional 3296 series
  Added Potentiometer Bourns 3266P
  Update with correct colour
  Added Potentiometer THT Bourns 3266 series
  Fixed step internal filename
  Renamed module to D1 mini light, as it seems that is the right name
  Added image to readme
  Added render of 3D model
  Added missing files
  Changed hole diameter, and alligned in StepUp
  Added 3D model and source for Wemos D1 Mini
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new package 3D to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants