This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
Seiko ms621 f #1218
Merged
Seiko ms621 f #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 26, 2018
poeschlr
added
Addition
|
The courtyard clearance is not quite right. The land pattern it self is ok.
|
poeschlr
added
Pending changes
and removed
Pending reviewer
|
Move the courtyard a little bit out
|
poeschlr
added
Ready for review
|
The bottom side connection between the arc and the horizontal line is open (by more than 0.01mm which is the maximum tolerance for the DRC algorithm to work.) |
poeschlr
added
Pending changes
and removed
Ready for review
|
Circle end have been moved |
poeschlr
added
Ready for review
|
looks good now. Thanks |
DaToBSn
pushed a commit
to DaToBSn/kicad-footprints
that referenced
this pull request
Jan 21, 2019
* 'master' of github.com:KiCad/kicad-footprints: (39 commits) Crystal: Add Abracon ABS25 4Pin 8.0x3.8mm (KiCad#1270) RJ45: Add a new Amphenol RJHSE5380-08 footprint (KiCad#1300) Add DFN-10 with EP 1.2x2 (KiCad#1290) Seiko ms621 f (KiCad#1218) Sip package link fixes (KiCad#1215) RF Module: Add CMWX1ZZABZ (KiCad#1296) Add L_Wuerth_WE-PD-Typ-7345. (KiCad#1299) Converter_DCDC XP_POWER IA, IH, ITX and ITQ series (KiCad#1058) More 3M Textool ZIF sockets, generated with script. (KiCad#495) Changed courtyard clearance to 0.25mm. Added Kyocera 6 pin tcxo. Add JST PHD series of connector footprints (KiCad#915) Rename Cherry MX1A to Cherry MX (KiCad#1180) RF_Module: Fix and improves HOPERF_RFM9XW_SMD footprint (KiCad#1213) Add vertical USB Type-C DX07S024WJ1 (KiCad#1251) Add PAT1220 RF attenuator. (KiCad#1288) Add RJ45_BEL_SS74301-00x (KiCad#1036) Add Texas R-PUQFN-N10 (KiCad#1310) Add LairdTech_28C0236-0JW-10 Ferrite bead (KiCad#1040) Fix courtyard and silkscreen ...
poeschlr
removed
the
Ready for review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When created the 3D model for battery holder Seiko MS621F
https://www.sii.co.jp/en/me/files/2014/02/file_EXTENDED_PRDCT_SPEC_75_FILE_11.jpg
It seems that the battery circles was off 0.4, earlier origo was at -4.6 but should be 5.0
Foot print push
#1218
3D model push
KiCad/kicad-packages3D#486
3D model script push
easyw/kicad-3d-models-in-freecad#245
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: