-
Notifications
You must be signed in to change notification settings - Fork 710
Fixed a bunch of outdated pad styles #981
base: master
Are you sure you want to change the base?
Conversation
Obviously a ton of Travis errors, mostly because these are old footprints. I'll work through them. |
Coilcraft LPS4018 https://www.coilcraft.com/pdfs/lps4018.pdf I update this footprint's custom pads so both appear in the current version of KSU. Here's an update showing just pad dimensions: |
This comment has been minimized.
This comment has been minimized.
https://www.rohm.com/datasheet/BU52014HFV/bu52004gul-e I fixed the courtyard after dimensioning this. |
https://www.fairchildsemi.com/datasheets/FD/FDMT80080DC.pdf I fixed the courtyard after dimensioning. |
http://ww1.microchip.com/downloads/en/DeviceDoc/3L_SOT-89_MB_C04-029C.pdf I kept the existing body width of 5mm even though this Microchip datasheet shows 4.5mm. |
I'm not sure what is the correct courtyard spacing for this. Should it be 0.25mm like other DFNs? 1mm like BGAs? Either way, it's not equal on all sides so something is wrong. |
That leaves the following questions
I wrote a short script to search libraries for the footprint used so that can help us track down some of the potential impact of the items above. |
I just pushed the last footprint I'm aware of that belongs in this group of footprints. In the original footprint pin 1 was at the top, but current KLC says it should be on the left. I haven't rotated the footprint for compatibility reasons. http://katalog.we-online.de/pbs/datasheet/7440310047.pdf This PR is now ready for review. Please see the questions above. |
@KiCad/librarians
Anyone oppose to trust him ? |
The main thing i would suggest to check is that all pads have zone connect set to solid instead of none (for polygon pads the default is none so it could easily happen. There sadly is no option to select thermals for polygon pads.) |
@poeschlr I disagree with having a solid connection on all pads because that will make soldering difficult, but if the only choices are Solid and None I understand why Solid must be chosen. Sigh. Please confirm the below and I'll update. @Misca1234 However, most of these footprints have only a few custom pads and so I believe we will then use the pad-specific connection setting seen here: We would not want Solid connection everywhere if it doesn't have to be, so we can do it per-pad on many footprints. |
Not sure why merging from master didn't bring this one in. Probably because I deleted it manually when I created a PR for just this footprint?
Conflict due to merging of #1459 to be fixed @evanshultz |
@evanshultz looking at the git diff, I'm not sure of the deletion of the two footprints we have discussed... |
Following the integration of the other PR, the new footprints just simply exist. |
@evanshultz is this still relevant or was it replaced with the other pull requests? |
I believe all changes here should be in separate PRs, but I kept this open as a 'meta' bug to track progress. |
@evanshultz i need to make footprint for Wuerth TPC with another size |
I believe all footprints in this PR have been split into smaller PRs which you can see linked below. So please do not merge this!
This is a big one, so grab a cup of coffee and sit down in a comfy chair. Or... you can trust me and merge with a quick review. :)
I set out to address footprints listed at #266, and I found a few more with outdated pad designs so I fixed them up too.
Changed multiple overlapping pads to a single custom pad:
Changed existing custom pads' zone connection:
Removed pin number from paste pads:
Merged multiple adjacent pads into a single one:
Other changes:
I left alone QFNs with odd-shaped corner pads and/or D-shaped pads since I believe Rene's fancy generator script can (or could) make them.
Dimensioned drawings and screenshots, where relevant, to follow.
Edit: Removed items that were split off into other PRs.
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: