Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Sot 89 custom pads #1702

Merged
merged 3 commits into from
Jan 6, 2020
Merged

Sot 89 custom pads #1702

merged 3 commits into from
Jan 6, 2020

Conversation

evanshultz
Copy link
Collaborator

@evanshultz evanshultz commented Jul 15, 2019

Breaking apart #981.

image
image

SOT-89-3 had no datasheet so I picked http://ww1.microchip.com/downloads/en/DeviceDoc/3L_SOT-89_MB_C04-029C.pdf and updated the footprint to match.

image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@evanshultz
Copy link
Collaborator Author

Regarding the body size above. I edited the comment. At #981 (comment) Rene said that the body size in the datasheet should match our footprint. I noted the governing body has the same size at #981 (comment). The part body was already changed but as I started at the top and made my way down the large number of comments in the old PR I didn't catch that earlier.

Hopefully this isn't a problem if there are wider parts that I didn't find since the existing body size is 5mm.

@antoniovazquezblanco antoniovazquezblanco added Enhancement Improves existing footprint in the library Pending reviewer A pull request waiting for a reviewer labels Jul 16, 2019
@poeschlr
Copy link
Collaborator

poeschlr commented Jan 6, 2020

Thanks for this great enhancement.

@poeschlr poeschlr merged commit c8f40a0 into KiCad:master Jan 6, 2020
@poeschlr poeschlr self-assigned this Jan 6, 2020
@poeschlr poeschlr removed the Pending reviewer A pull request waiting for a reviewer label Jan 6, 2020
@evanshultz evanshultz deleted the sot-89-custom-pads branch January 6, 2020 21:31
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing footprint in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants