Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Finish #584: Würth 7499010121A ethrenet magjack #883

Merged
merged 7 commits into from
Sep 11, 2018

Conversation

poeschlr
Copy link
Collaborator

This finishes the remaining points of #584
Symbol PR: KiCad/kicad-symbols#603

Datasheet http://katalog.we-online.de/pbs/datasheet/7499010121A.pdf

screenshot from 2018-08-28 02-12-45

hvraven and others added 4 commits May 15, 2018 23:01
- moved Silk screen closer to housing, broke lines where necessary.
- renamed to follow KLC guidelines
- moved keywords to description
- fixed courtyard (still excluding mounting holes)
- Rotate part to get pin 1 nearer to top left corner
- Include NPTH pads in courtyard area
- Ensure silk clearance around pads
@Shackmeister
Copy link
Collaborator

Hey @poeschlr
Can you please adress the following;

  • Courtyard not on grid (as travis says)

  • Chamfered corner on the fab line isn't really pointing to pin 1, a triangle would probably fit better

  • I think we usually only use a line to indicate pin 1 on silk, but I might be wrong

  • a few silk lines are hitting the solder mask with the 0,2mm clearance

- Put courtyard on grid
- Silk pad clearance
- Better pin 1 markers on fab and silk
@poeschlr
Copy link
Collaborator Author

poeschlr commented Sep 6, 2018

Fixed:

screenshot from 2018-09-06 23-08-15

@Shackmeister
Copy link
Collaborator

Shackmeister commented Sep 8, 2018

@poeschlr
is it on purpose you set the pad clearance to 0,2mm? or was it only intended for checking? also should Travis accept this? Travis does actually make a warning

and if we are being extremely pedantic, this is still in the 0,2mm zone :p
rj45_wurth

@poeschlr
Copy link
Collaborator Author

poeschlr commented Sep 9, 2018

I forgot to push the fix for the clearance (had it already locally. Was quite confused when i tried to fix it.)

Edit: The silk is in contact with the clearance line. for me this means it is outside the 0.2mm area (just outside) But to be honest we can not really trust kicad that much here. It approximates the clearance line using a polygon so it is not that precise.

@Shackmeister
Copy link
Collaborator

Might be true :) I just noticed the upper line (mirrored across X) was ending at 6,86 in order to stay totally clear, and the lower one was ending at 6,85 :)

@Shackmeister Shackmeister merged commit 6a21beb into KiCad:master Sep 11, 2018
@ghost
Copy link

ghost commented Oct 9, 2018

I found a small issue: The two inner mechanical pins should have plated holes, so the pegs can be soldered.
Currently they are non-plated.

@poeschlr
Copy link
Collaborator Author

poeschlr commented Oct 9, 2018

Are these pegs connected to the shield? Or are they only for adding mechanical strength?

@ghost
Copy link

ghost commented Oct 9, 2018

They definitely are requited for mechanical strength.
And they are connected to the metal housing as well. So I would say yes, they are part of the shield.
That would mean the symbol needs another pin :/

@poeschlr poeschlr deleted the finish_pr584 branch December 16, 2018 14:04
@myfreescalewebpage myfreescalewebpage added the Addition Adds new footprint to library label May 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants