Skip to content
This repository was archived by the owner on Oct 2, 2020. It is now read-only.

new footprint Würth 7499010121A ethrenet magjack #584

Merged
merged 3 commits into from
Sep 11, 2018
Merged

new footprint Würth 7499010121A ethrenet magjack #584

merged 3 commits into from
Sep 11, 2018

Conversation

hvraven
Copy link
Contributor

@hvraven hvraven commented May 15, 2018

datasheet
Matching symbol PR
screenshot_20180515_230517

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@evanshultz
Copy link
Collaborator

evanshultz commented May 22, 2018 •
edited
Loading

  • Please snuggle the silk lines just 0.11mm offset from the fab lines. You will have to break those lines where they pass too close to a pad.
  • Change - to _ in the footprint name and add a trailing _Horizontal. See the existing one in https://github.com/KiCad/kicad-footprints/tree/master/Connector_RJ.pretty.
  • Please move your keywords info to the description along with the datasheet and add just simple keywords.
  • Only the courtyard clearance is off dimensionally. It should be 0.5mm all around:
    image

@poeschlr
On this footprint should the horizontal courtyard be from the body or the outside of the 1.6mm mounting holes?

@evanshultz evanshultz self-assigned this May 22, 2018
@hvraven
RJ45 7499010121A: integrate evanshultz feedback
ad3c6e5 
- moved Silk screen closer to housing, broke lines where necessary.
- renamed to follow KLC guidelines
- moved keywords to description
- fixed courtyard (still excluding mounting holes)
@hvraven
Copy link
Contributor Author

hvraven commented May 28, 2018

I integrated your feedback and fixed the broken courtyard. I think I included the markings on the silk screen, but in this case they were weird.
I did not include the mounting holes in the courtyard as the mounting holes are in line with the package and do not extend further.
screenshot_20180528_133531

@evanshultz
Copy link
Collaborator

@lorem-ipsum

  • Please use horizontal instead of side entry in the description.

@poeschlr
Please see the question above about the courtyard so I can finish reviewing this. Thanks!

@evanshultz
Copy link
Collaborator

The 1.6mm mounting holes do count. Please widen the courtyard to accommodate them (-13.645mm and +4.755mm). The top and bottom courtyard look fine now. Thanks!

I just remembered that pin 1 should be top left. See http://kicad-pcb.org/libraries/klc/F4.2/. Can you rotate the connector to do that?

@poeschlr poeschlr mentioned this pull request Aug 28, 2018
Merged
@poeschlr
Copy link
Collaborator

Remaining points finished in #883

@poeschlr poeschlr added the Finished in new PR This pull request is finished by somebody else in a new pull request label Aug 28, 2018
@Shackmeister Shackmeister merged commit 53d69e4 into KiCad:master Sep 11, 2018
Shackmeister added a commit that referenced this pull request Sep 11, 2018
@Shackmeister
Merge pull request #883 from poeschlr/finish_pr584
6a21beb 
Finish #584: Würth 7499010121A ethrenet magjack
@hvraven hvraven deleted the 7499010121A branch September 20, 2018 06:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@evanshultz evanshultz

Labels
Finished in new PR This pull request is finished by somebody else in a new pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hvraven @evanshultz @poeschlr @Shackmeister