fix alignment of guard blocks #4137
Open
+15
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
GUARD_BLOCKSfeature that is enabled whenNDEBUGis not specified can cause unaligned memory allocations. This was causing Emscripten debug builds to throw alignment faults when-sSAFE_HEAP=2, and causing Safari to leak large amounts of memory when safe heap was disabled.this change simply fixes the guard block size logic to ensure the combined header+guard size is 16-byte aligned which I believe was the intention.
Also, I realize the leak claim sounds crazy, and if true is clearly a safari bug, but fixing alignment issue is still a good idea. Also here is a simple repro.