Update bptc and rgtc tests with level and dimension test #3112
Conversation
kenrussell
left a comment
kenrussell
left a comment
There was a problem hiding this comment.
LGTM. Out of curiosity has this been tested with revised validation code in ANGLE and/or Chromium?
Let's see if @lexaknyazev and @jdashg have any comments; we can merge this tomorrow.
| gl.deleteTexture(tex); | ||
| }; | ||
|
|
||
| var testTexImageLevelDimensions = function(gl, validFormats, expectedByteLength, getBlockDimensions, imageConfigs) { |
There was a problem hiding this comment.
Might be a good time to start changing "var" to "let", at least inside this function.
The level validation already passed on Win (using D3D angle). |
kenrussell
left a comment
kenrussell
left a comment
There was a problem hiding this comment.
Sounds good; please post here once you've verified these test changes with the fixed validation code.
|
FYI. Local test on Mac Chromium shows updated validation code passed the new test. |
|
Thanks for confirming. Merging now. |
Fixing several BPTC and RGTC texture validation logic according to recent WebGL spec and test updates: KhronosGroup/WebGL#3105 KhronosGroup/WebGL#3111 KhronosGroup/WebGL#3112 Bug: 1100834, 1102924 Change-Id: I82938a642821308a08e6f73175553f312c1c0e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285179 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#786536}
2 participants
Updating test according to recent change: #3111
addressing chrome issue: http://crbug.com/1100834