Clarified WebGL-specific dimensions restrictions for RGTC and BPTC #3111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenrussell
approved these changes
Jul 7, 2020
Member
kenrussell
left a comment
kenrussell
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks @lexaknyazev for putting this together.
@shrekshao what do you think?
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Jul 9, 2020
Fixing several BPTC and RGTC texture validation logic according to recent WebGL spec and test updates: KhronosGroup/WebGL#3105 KhronosGroup/WebGL#3111 KhronosGroup/WebGL#3112 Bug: 1100834, 1102924 Change-Id: I82938a642821308a08e6f73175553f312c1c0e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285179 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#786536}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by discussion on http://crbug.com/1100834 .