Skip to content

Test uploading an image with a srcset with empty data. #3087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenrussell merged 1 commit into from
May 29, 2020
Merged

Test uploading an image with a srcset with empty data. #3087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/tests/conformance/textures/misc/00_test_list.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,4 @@ texture-transparent-pixels-initialized.html
--min-version 1.0.3 texture-upload-size.html
--min-version 1.0.4 texture-video-transparent.html
--min-version 1.0.4 texture-with-flip-y-and-premultiply-alpha.html
--min-version 1.0.4 upload-from-srcset-with-empty-data.html
44 changes: 44 additions & 0 deletions sdk/tests/conformance/textures/misc/upload-from-srcset-with-empty-data.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
<!--
Copyright (c) 2020 The Khronos Group Inc.
Use of this source code is governed by an MIT-style license that can be
found in the LICENSE.txt file.
-->

<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<link rel="stylesheet" href="../../../resources/js-test-style.css"/>
<title>Upload From Srcset With Empty Data</title>
<script src="../../../js/js-test-pre.js"></script>
<script src="../../../js/webgl-test-utils.js"></script>
</head>
<body>
<div id="description"></div>
<div id="console"></div>
<img srcset="data:,a 1x, data:,b 1w" id="i">
<script>
"use strict";
var wtu = WebGLTestUtils;

var successfullyParsed;

description("This test ensures WebGL implementations handle srcsets with empty data.");
debug("Regression test for <a href='http://crbug.com/1085044'>http://crbug.com/1085044</a>");

let gl = wtu.create3DContext();

// Note we run this test synchronously, rather than running it in an async
// function called after "wtu.awaitOrTimeout(img.decode());". This reproduces
// the bug more reliably.
let img = document.getElementById("i");
let tex = gl.createTexture();
gl.bindTexture(gl.TEXTURE_2D, tex);
// Implementations can decide how to respond to these kinds of bad
// inputs, as long as they don't crash.
gl.texImage2D(gl.TEXTURE_2D, 0, gl.RGBA, gl.RGBA, gl.UNSIGNED_BYTE, img);

finishTest();
</script>
</body>
</html>