Test uploading an image with a srcset with empty data. #3087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression test for http://crbug.com/1085044 .
Member
Author
|
Test passes in current Firefox and Safari. |
Member
Author
|
@jdashg or @jdarpinian or @shrekshao please review. Thanks. |
shrekshao
approved these changes
May 29, 2020
Member
shrekshao
left a comment
shrekshao
left a comment
There was a problem hiding this comment.
LGTM with the context of the crbug
Member
Author
|
Thanks Shrek for your review. Merging myself. |
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
May 29, 2020
Regression test being added to WebGL conformance suite in KhronosGroup/WebGL#3087 . Bug: 1085044 Change-Id: I2bf2f58a61e42dc360fe6e9c2fb54a4ec896dc5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220812 Reviewed-by: Shrek Shao <shrekshao@google.com> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#773254}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression test for http://crbug.com/1085044 .