Remove setTimeout() from GLSLConformanceTester.runTests() #2612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@zhenyao, please review when you get a chance |
Contributor
|
LGTM |
Member
|
For what it's worth, I think this was made asynchronous to allow the web browser to update its output while these potentially long-running tests were running. But as long as the tests continue to work reasonably well in all harnesses, simplifying it sounds good. Sorry for the long delay in commenting on this. |
kenrussell
added a commit
to kenrussell/WebGL
that referenced
this pull request
Jul 27, 2020
Backport fixes from KhronosGroup#2330 and KhronosGroup#2612 to the 2.0.0 snapshot.
kenrussell
added a commit
that referenced
this pull request
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLSLConformanceTester.runTests() uses setTimeout(.., 1) in between tests, making the tests asynchronous. runOneTest(), the function called in the setTimeout callback, doesn't do intensive work that takes a long time, and it does a checkCanvas at the end of the function that would reset the harness timeout timer. Changing this to a synchronous for loop instead.
This PR is a followup from #2608