Use GLSL test framework for tests that need to set uniforms #2330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unifies test output and reduces duplication of trivial code without losing coverage.
Contributor
|
Great refactoring! LGTM |
xlai-o
pushed a commit
to xlai-o/WebGL
that referenced
this pull request
Apr 18, 2017
…roup#2330) This unifies test output and reduces duplication of trivial code without losing coverage.
kenrussell
added a commit
to kenrussell/WebGL
that referenced
this pull request
Jul 27, 2020
Backport fixes from KhronosGroup#2330 and KhronosGroup#2612 to the 2.0.0 snapshot.
kenrussell
added a commit
that referenced
this pull request
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies test output and reduces duplication of trivial code
without losing coverage.