Add Alignment Imposition #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ec' load/store method
|
|
gmlueck
reviewed
Dec 7, 2023
|
@AD2605: I think we are waiting for you to update this PR. |
AerialMantis
approved these changes
Dec 14, 2023
gmlueck
approved these changes
Dec 14, 2023
gmlueck
added
Agenda
keryell
reviewed
Dec 14, 2023
|
@keryell do you mean the original sentence before the review comment this PR was proposing to add ? |
|
@AD2605 will improve first sentence in description also. |
gmlueck
reviewed
Jan 3, 2024
gmlueck
approved these changes
Jan 4, 2024
|
BTW, feel free to add yourself to the list of Contributors in "adoc/acknowledgements.adoc". |
|
Done |
gmlueck
reviewed
Jan 4, 2024
nliber
approved these changes
Jan 4, 2024
keryell
requested changes
Jan 11, 2024
| @@ -17230,15 +17230,15 @@ a@ | |||
| template <access::address_space AddressSpace, access::decorated IsDecorated> | |||
| void load(size_t offset, multi_ptr<const DataT, AddressSpace, IsDecorated> ptr) | |||
| ---- | |||
| a@ Loads the values at the address of [code]#ptr# offset in elements of type [code]#DataT# by [code]#NumElements * offset#, into the components of this SYCL [code]#vec#. | |||
| a@ Loads [code]#NumElements# elements into the components of this SYCL [code]#vec#. These elements are loaded from consecutive addresses, where the starting address is computed by adding [code]#offset * NumElements * sizeof(DataT)# bytes to the address specified by the [code]#ptr#. The ptr must be aligned to [code]#alignof(DataT)#. | |||
There was a problem hiding this comment.
Suggested change
| a@ Loads [code]#NumElements# elements into the components of this SYCL [code]#vec#. These elements are loaded from consecutive addresses, where the starting address is computed by adding [code]#offset * NumElements * sizeof(DataT)# bytes to the address specified by the [code]#ptr#. The ptr must be aligned to [code]#alignof(DataT)#. | |
| a@ Loads [code]#NumElements# elements into the components of this SYCL [code]#vec#. These elements are loaded from consecutive addresses, where the starting address is computed by adding [code]#offset * NumElements * sizeof(DataT)# bytes to the address specified by the [code]#ptr#. The [code]#ptr# must be aligned to [code]#alignof(DataT)#. |
Feel free to shorten the line.
There was a problem hiding this comment.
Thanks, added ptr inside the code section (conversation got automatically resolved as I committed the suggestion)
Co-authored-by: Ronan Keryell <ronan.keryell@amd.com>
|
WG approved, pleased merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imposes an alignment requirements on the vectors passed to SYCL' vector class'
load/storemethod.Fixes the issue described in #508