Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic vertex stride with tessellation. #2429

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

squidbus
Copy link
Contributor

Updates the compute-based vertex shader path for tessellation to take into account the dynamic vertex binding stride, when enabled for the pipeline, in the same fashion as regular vertex bindings.

Fixes #2428

@italomandara
Copy link
Contributor

Quick question about ShadPS4:
are those changes already included in a custom version of MVK bundled in ShadPS4 pre-releases or are you waiting those to be merged?

@squidbus
Copy link
Contributor Author

Quick question about ShadPS4: are those changes already included in a custom version of MVK bundled in ShadPS4 pre-releases or are you waiting those to be merged?

I'd rather keep discussion here specifically about MoltenVK, but no, I don't include anything that hasn't landed upstream here yet.

Copy link
Collaborator

@cdavis5e cdavis5e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@cdavis5e cdavis5e merged commit 6fa077f into KhronosGroup:main Jan 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic vertex stride does not seem to be working with tessellation
3 participants