Support array and 3d textures. #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 21, 2024
* Fix array & 3d texture creation. * Disable mipmap generation for 3d textures as they need completely different resampling code. * Add tests. * Fix ktxTexture2_SetImageFromStream's failure to check the return value of ktxTexture_GetImageOffset. Co-authored-by: unknown <tuketet@gmail.com>
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
* Fix array & 3d texture creation. * Disable mipmap generation for 3d textures as they need completely different resampling code. * Add tests. * Fix ktxTexture2_SetImageFromStream's failure to check the return value of ktxTexture_GetImageOffset. Co-authored-by: unknown <tuketet@gmail.com>
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
* Fix array & 3d texture creation. * Disable mipmap generation for 3d textures as they need completely different resampling code. * Add tests. * Fix ktxTexture2_SetImageFromStream's failure to check the return value of ktxTexture_GetImageOffset. Co-authored-by: unknown <tuketet@gmail.com>
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
* Fix array & 3d texture creation. * Disable mipmap generation for 3d textures as they need completely different resampling code. * Add tests. * Fix ktxTexture2_SetImageFromStream's failure to check the return value of ktxTexture_GetImageOffset. Co-authored-by: unknown <tuketet@gmail.com>
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
* Fix array & 3d texture creation. * Disable mipmap generation for 3d textures as they need completely different resampling code. * Add tests. * Fix ktxTexture2_SetImageFromStream's failure to check the return value of ktxTexture_GetImageOffset. Co-authored-by: unknown <tuketet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #461 by @tuket. Fixes #454.