support array textures #461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase this on current master. The reason is I want to add tests as part of this PR but when I pull it locally to do that work, I have to do a merge. I don't want a merge bubble. With this fix, arrays are being correctly generated. Thanks. Haven't tested 3D textures yet. |
tuket
force-pushed
the
support_array_textures
branch
from
ff69ed0
to
9c6702a
Compare
|
Hi, |
|
I have just created PR #468 which builds on this. You array texture fixes are correct. 3d textures still had many problems. Thank you for providing the starting point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm trying to add array-texture support to toktx.
What do you think about this? It seems to work but I might have missed something.
Thanks!