Skip to content

fix: surface unexpected repeat time-off failures - #1473

Merged
Kevinjohn merged 3 commits into
mainfrom
feature/issue-1467-comment-style
Oct 11, 2026
Merged

Kevinjohn merged 3 commits into
mainfrom
feature/issue-1467-comment-style

Conversation

@Kevinjohn

@Kevinjohn Kevinjohn commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Surface unexpected failures during repeat time-off requests while preserving validation feedback for invalid dates.
  • Add regression coverage for repeat time-off error handling.

Validation

  • pnpm run gate:all passed.
  • pnpm run e2e passed (294 tests).

Merge predecessor: #1472

Closes #1467

Merge order

#1472 → #1473, #1474, #1466

Merge predecessor for this PR: #1472.

Conflicts: none.

Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
@Kevinjohn

Copy link
Copy Markdown
Owner Author

Polish review: no P1 or P2 findings, no changes pushed.

  • Comment-stripped AST comparison limits the behaviour change to useTimeOffRepeat.ts, repeatingTimeOff.ts, the regenerated primitive hashes in check-ui-primitives.mjs and two removed JSX comments in CommandPalette.tsx.
  • Behaviour verified: a probe over 144 edge combinations (year 9999 and 0001 starts, end before start, every cadence, cutoffs at the start, end and policy maximum) produced only RepeatingDateError or a valid projection, so the preview's narrowed catch cannot crash the form on user input. The save path in timeOffFormSubmission.ts maps the new invalid-date code to the same date-domain message the old RangeError branch showed.
  • node scripts/check-ui-primitives.mjs passes with the new hashes; the time-off, repeat, design-token, command palette, UI primitive and enlarged test files pass (17 files, 301 tests).
  • Ladder passed on Node 24 at the PR head: pnpm run check:push (format, typecheck, lint with zero warnings, file-size policy) and pnpm run policy:comment-voice.
  • Integration: chore: align repository configuration comments #1471, chore: align server, shared, and script comments #1472, fix: surface unexpected repeat time-off failures #1473, chore: clarify E2E test comments #1474 and Rewrite the documentation front door around four role quick starts #1466 merged in that order onto main at 8141c39 without conflicts; check:push, policy:comment-voice, docs:build (tree clean afterwards) and the documentation, runbook and user-story suites (430 tests) pass on the combined tree.

Merge predecessor: #1472.

@Kevinjohn
Kevinjohn merged commit 0718981 into main Oct 11, 2026
4 checks passed
@Kevinjohn
Kevinjohn deleted the feature/issue-1467-comment-style branch October 11, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

polish-done Polish review complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align comments in application source with the house style

1 participant