Skip to content

chore: align server, shared, and script comments - #1472

Merged
Kevinjohn merged 4 commits into
mainfrom
feature/issue-1468-comment-style
Oct 11, 2026
Merged

Kevinjohn merged 4 commits into
mainfrom
feature/issue-1468-comment-style

Conversation

@Kevinjohn

@Kevinjohn Kevinjohn commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

Closes #1468

Aligns TSDoc and source comments in server/, shared/, and scripts/ with DEFENSIVE-CODING.md section 7. Removes stale history and adds contract documentation while preserving authorization, tenancy, migration, audit, recovery, and validation behavior. The accepted-syntax notes in scripts/check-comment-voice.mjs remain because they describe checker inputs. The @vite-ignore directive remains inline because the dynamic import requires it.

The shared entity allocation note requested by #1467 is removed here; #1467 must merge after this PR. Redundant test comments were removed where they only repeated adjacent assertions. The required TSDoc puts server/src/routes/entityRoutes.ts two lines over its ceiling, so its existing ratchet policy records a temporary 402-line baseline for a future module split.

Validation:

  • Pre-push checks: Prettier, typecheck, lint, and file-size policy
  • Comment-style checker across 1,301 source files
  • git diff --check

No application test suites were run because this change only edits comments.

Merge predecessor: none. #1467 must merge after this PR.

Merge order

#1472 → #1473, #1474, #1466

Merge predecessor for this PR: none.

Conflicts: none.

Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
@Kevinjohn

Copy link
Copy Markdown
Owner Author

Polish review: no P1 or P2 findings, no changes pushed.

Merge predecessor: none. #1473 follows this PR.

@Kevinjohn
Kevinjohn merged commit 5a3ccba into main Oct 11, 2026
5 checks passed
@Kevinjohn
Kevinjohn deleted the feature/issue-1468-comment-style branch October 11, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

polish-done Polish review complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align comments in server, shared, and script code with the house style

1 participant