Repository navigation
chore: align server, shared, and script comments - #1472
Merged
Merged
Conversation
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Signed-off-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Owner
Author
|
Polish review: no P1 or P2 findings, no changes pushed.
Merge predecessor: none. #1473 follows this PR. |
This was referenced Oct 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1468
Aligns TSDoc and source comments in server/, shared/, and scripts/ with DEFENSIVE-CODING.md section 7. Removes stale history and adds contract documentation while preserving authorization, tenancy, migration, audit, recovery, and validation behavior. The accepted-syntax notes in scripts/check-comment-voice.mjs remain because they describe checker inputs. The @vite-ignore directive remains inline because the dynamic import requires it.
The shared entity allocation note requested by #1467 is removed here; #1467 must merge after this PR. Redundant test comments were removed where they only repeated adjacent assertions. The required TSDoc puts server/src/routes/entityRoutes.ts two lines over its ceiling, so its existing ratchet policy records a temporary 402-line baseline for a future module split.
Validation:
No application test suites were run because this change only edits comments.
Merge predecessor: none. #1467 must merge after this PR.
Merge order
#1472 → #1473, #1474, #1466
main(2950329) or between any pair of the remaining PRs. All four merged in this order ontomaincleanly, and the combined tree passes format, typecheck, lint and the docs build (tree clean).docs/output.mainonce its predecessor lands; update the branch frommainbefore merging.Merge predecessor for this PR: none.
Conflicts: none.