fixed lookup bug for double free (vesoft-inc#1855)

* fixed lookup bug for double free * improved scan logic, return error directly when any part error occur. Co-authored-by: dangleptr <37216992+dangleptr@users.noreply.github.com>
KevinLuuu · Mar 5, 2020 · 0f2ce83 · 0f2ce83
1 parent 72af573
commit 0f2ce83
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/storage/index/LookUpEdgeIndexProcessor.cpp b/src/storage/index/LookUpEdgeIndexProcessor.cpp
@@ -31,7 +31,7 @@ void LookUpEdgeIndexProcessor::process(const cpp2::LookUpIndexRequest& req) {
     /**
      * step 3 : execute index scan.
      */
-    std::for_each(req.get_parts().begin(), req.get_parts().end(), [&](auto& partId) {
+    for (auto partId : req.get_parts()) {
         auto code = executeExecutionPlan(partId);
         if (code != kvstore::ResultCode::SUCCEEDED) {
             VLOG(1) << "Error! ret = " << static_cast<int32_t>(code)
@@ -45,7 +45,7 @@ void LookUpEdgeIndexProcessor::process(const cpp2::LookUpIndexRequest& req) {
             this->onFinished();
             return;
         }
-    });
+    }
 
     /**
      * step 4 : collect result.

diff --git a/src/storage/index/LookUpVertexIndexProcessor.cpp b/src/storage/index/LookUpVertexIndexProcessor.cpp
@@ -31,7 +31,7 @@ void LookUpVertexIndexProcessor::process(const cpp2::LookUpIndexRequest& req) {
     /**
      * step 3 : execute index scan.
      */
-    std::for_each(req.get_parts().begin(), req.get_parts().end(), [&](auto& partId) {
+    for (auto partId : req.get_parts()) {
         auto code = executeExecutionPlan(partId);
         if (code != kvstore::ResultCode::SUCCEEDED) {
             VLOG(1) << "Error! ret = " << static_cast<int32_t>(code)
@@ -45,7 +45,7 @@ void LookUpVertexIndexProcessor::process(const cpp2::LookUpIndexRequest& req) {
             this->onFinished();
             return;
         }
-    });
+    }
 
     /**
      * step 4 : collect result.