fixed lookup bug for double free #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bright-starry-sky
requested review from
monadbobo,
darionyaphet,
critical27,
dangleptr and
liuyu85cn
dangleptr
reviewed
Mar 4, 2020
| @@ -42,8 +42,6 @@ void LookUpEdgeIndexProcessor::process(const cpp2::LookUpIndexRequest& req) { | |||
| } else { | |||
| this->pushResultCode(this->to(code), partId); | |||
| } | |||
| this->onFinished(); | |||
There was a problem hiding this comment.
Emm.. I don't think we need any return here. because this is last line of lambda block. Is there any other intention?
There was a problem hiding this comment.
We don't return now?
let me improve the logic, let return directly when any part error occur.
|
Improved the logic, return error directly when any part fail occur. |
bright-starry-sky
added
ready-for-testing
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* fixed lookup bug for double free * improved scan logic, return error directly when any part error occur. Co-authored-by: dangleptr <37216992+dangleptr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed lookup bug .
Issus #1853