Repository navigation
Conversation
The phone panel is a vertical flex, where .content's implicit min-height: auto refused to shrink: the column ran past the panel edge, .options never engaged its overflow-y, and the bottom slice of the settings content sat clipped and unreachable behind the panel's overflow: hidden. Declare min-height: 0 on .content (a no-op in the desktop row direction). The phone-form e2e settings case now asserts the scroller's geometry — bottom edge inside the viewport, scrollHeight beyond clientHeight, programmatic scroll reaching maxScrollTop.
…ngs case
SVG descendants expose className as SVGAnimatedString, which has no
includes; getAttribute('class') is element-type agnostic.
fix(ui-settings-general): let the phone settings sheet scroll again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the last release point
/contextcommand (command-context package) + ContextInspector service injection fixContextsurfaces withdrawn from the Web UI.contentmin-height: 0; regression assertions in phone-form e2e)All PRs landed with full green CI (tests, typecheck, lint, doc-sync 29 gates, web e2e replay).