-
Notifications
You must be signed in to change notification settings - Fork 78
Improved logging, fix unicode error, include_dir buildrun #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aaac68f to
97610ba
Compare
97610ba to
a6d1e79
Compare
a6d1e79 to
b850e32
Compare
|
Okay, I'm quite happy with this now. Changes:
|
1fdea4c to
a2d8a58
Compare
pehrsoderman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment regarding pep8.
b71598c to
3c3815b
Compare
3c3815b to
ad31064
Compare
I've found that this makes the output look rather uglier. Where previously I had I now get I would prefer to revert the use of |
|
I 100% agree with the text wrapping being worse now than previously. I do see great value in categorization of the log messages but I'd also prefer it to not look this way when running verifyproblem in default log level outputting to stdout. |
This is due to PlasTeX completely butchering the logging framework in a (near) irreparable way. Which is why I wanted to delay loading it.
The correct "fix" for this is to remove eagerly importing plastex and, if needed, define a logging format that is applied in EDIT: I can do that if wanted! |
This replaces #209 (I migrated the repository) and fixes #201