Improved logging, fix unicode error, include_dir buildrun #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pehrsoderman
requested changes
May 1, 2023
Contributor
pehrsoderman
left a comment
pehrsoderman
left a comment
There was a problem hiding this comment.
There seems to be some debugging related changes left in this pr...
| _JUNK_CASES = [ | ||
| ('an empty file', b''), | ||
| ('a binary file with byte values 0 up to 256', bytearray(x for x in range(256))), | ||
| # ('a binary file with byte values 0 up to 256', bytearray(x for x in range(256))), |
Contributor
There was a problem hiding this comment.
Why is this case removed?
| if sys.stdout.isatty(): | ||
| sys.stdout.write('%s' % '\b \b' * (len(msg))) | ||
| # if sys.stdout.isatty(): | ||
| # sys.stdout.write('%s' % '\b \b' * (len(msg))) |
Contributor
There was a problem hiding this comment.
Why is this commented out?
Contributor
Author
|
Hey, sorry, I switched institutions two times this year and somehow completely forgot that this is open. Should I update this to the current release? |
Contributor
|
@incaseoftrouble Please do a rebase |
Contributor
Author
|
Just as a remark on that: My schedule is absolutely full, I put this into my calendar for February. (But I put it in!) |
Contributor
Author
|
Moved to #253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm using problemtools as library in a larger script to automate deployment of lectures. In that process I found some things I thought needed fixing. I tried to keep changes small and can also make them a bit more consistent. Depending on your wishes, I might address some more things in the future :-)
Mainly, I introduced a bit more consistent logging and added the possibility of having
build/runin the include_dir. I used this for some java validators where a common build script lies in an included dir.Closes #201