POSTPONED: VPN from within container #126
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ME contains certain keywords
…, this is very slow This reverts commit a67405e.
…sting test by checking output
…tainer) and pulling it from there. This required additional changes: * changed name of Docker image for testing to localhost:5000/…, which should also prevent accidental push * parse name of Docker image from swarm project description yml rather than use hard-coded name * extended "delete old image versions" script accordingly
…PN from within the container. Currently requires manual steps (at least building the VPN container) for the test to succeed and will need to be adapted for productive VPN use. * install packages for OpenVPN and debugging in ODELIA container * changed docker run arguments for swarm nodes to be able to open VPN connection from within (currently as root, to be reconsidered) * setup for building and VPN container, creating OpenVPN certificates (one fixed set committed), running VPN container * swarm server now named testserver.local, but this name only needs to be reachable in the containers * VPN container is assumed to be reachable on host at 172.17.0.1 from other containers * changed ports for nvflare server to avoid interference with productive servers * noted TODOs * added integration test checking that and documenting how this works
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 21197632 | Triggered | Generic Private Key | 25e7322 | tests/local_vpn/client_configs/admin@test.odelia_client.ovpn | View secret |
| 21197633 | Triggered | Generic Private Key | 25e7322 | tests/local_vpn/client_configs/client_B_client.ovpn | View secret |
| 21197634 | Triggered | Generic Private Key | 25e7322 | tests/local_vpn/client_configs/client_A_client.ovpn | View secret |
| 21197635 | Triggered | Generic Private Key | 25e7322 | tests/local_vpn/client_configs/testserver.local_client.ovpn | View secret |
| 21197636 | Triggered | Generic Private Key | 25e7322 | tests/local_vpn/server_config/server.key | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…rt openvpn in Docker, added name resolution to docker run call
oleschwen
force-pushed
the
dev-122-vpn-from-within-container
branch
from
255ad91 to
0d1f098
Compare
…der with VPN credentials) needed now
oleschwen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test setup for connecting to VPN from inside the MediSwarm containers rather than on the host, including a setup for locally running an openvpn server. Postponed, as we do not need this for now.
The branch contains credentials used for the test setup, warnings about this can be ignored.