Fixes #25142 - fix extending module_streams api docs #7827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #25142 |
|
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
iNecas
force-pushed
the
modularity-update-api
branch
from
fa0b28b
to
da017c2
Compare
|
Works when tested with apipie PR, just needs the new release + bump. Thanks for fixing this! 🙏 |
`update_api` is only usable from within a concern. When extending an API inside controller that's coming from concern, `apipie_update_params` should be used instead. Also, there has been an issue on apipie side, that prevented merging top-level params (see Apipie/apipie-rails#642). Both changes are needed in order for this issue to be resolved.
iNecas
force-pushed
the
modularity-update-api
branch
from
da017c2
to
c641b48
Compare
|
New apipie-rails version has been released and the dependency has been bumped. This PR should be ready for final re-review and merge. |
johnpmitsch
approved these changes
Nov 16, 2018
|
@iNecas is there a package release for this new apipie-rails requirement? |
|
There is now theforeman/foreman-packaging#3208 |
|
Well, a PR is there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update_apiApipie/apipie-rails#642update_apiis only usable from within a concern. When extending an APIinside controller that's coming from concern,
apipie_update_paramsshould beused instead.
Also, there has been an issue on apipie side, that prevented merging top-level
params (see Apipie/apipie-rails#642).
Both changes are needed in order for this issue to be resolved.