Support for adding new params via update_api
#642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, we only supported updating nested hashes. For example
param :user, Hash do
param :login, String
end
and
param :user, Hash do
param :oauth, String
end
has been merged properly. However when merging top-level params, such as
param :login, String
and
param :oauth, String
no changes were propagated.
iNecas
added a commit
to iNecas/katello
that referenced
this pull request
Nov 9, 2018
`update_api` is only usable from within a concern. When extending an API inside controller that's coming from concern, `apipie_update_params` should be used instead. Also, there has been an issue on apipie side, that prevented merging top-level params (see Apipie/apipie-rails#642). Both changes are needed in order for this issue to be resolved.
1 task
iNecas
added a commit
to iNecas/katello
that referenced
this pull request
Nov 9, 2018
`update_api` is only usable from within a concern. When extending an API inside controller that's coming from concern, `apipie_update_params` should be used instead. Also, there has been an issue on apipie side, that prevented merging top-level params (see Apipie/apipie-rails#642). Both changes are needed in order for this issue to be resolved.
In some Ruby implementations, we couldn't rely on specific order in the hash. The new matcher implementation doesn't rely on the order.
|
As a bonus, I've also fixed the intermittent test failure we've seen in master for past several weeks. @iNecas is ready for the weekend :) |
johnpmitsch
approved these changes
Nov 13, 2018
There was a problem hiding this comment.
works for me!
Tested with Katello/katello#7827
On master katello and master apipie-rails, the name_stream_only and host_id params are missing:
And they are there with this and the Katello PR
|
Thanks for feedback. Merging now |
|
apipie-rails-0.5.14 has just been released, including this fix |
iNecas
added a commit
to iNecas/katello
that referenced
this pull request
Nov 16, 2018
`update_api` is only usable from within a concern. When extending an API inside controller that's coming from concern, `apipie_update_params` should be used instead. Also, there has been an issue on apipie side, that prevented merging top-level params (see Apipie/apipie-rails#642). Both changes are needed in order for this issue to be resolved.
johnpmitsch
pushed a commit
to Katello/katello
that referenced
this pull request
Nov 16, 2018
`update_api` is only usable from within a concern. When extending an API inside controller that's coming from concern, `apipie_update_params` should be used instead. Also, there has been an issue on apipie side, that prevented merging top-level params (see Apipie/apipie-rails#642). Both changes are needed in order for this issue to be resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, we only supported updating nested hashes. For example
and
has been merged properly. However when merging top-level params, such as
and
no changes were propagated.