Skip to content

fix(pds-dropdown-menu): prevent clipping in overflow containers #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pixelflips merged 2 commits into from
Jan 23, 2026
Merged

fix(pds-dropdown-menu): prevent clipping in overflow containers #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c198ac9
fix(pds-dropdown-menu): use fixed positioning to prevent clipping in …
pixelflips Jan 23, 2026
2625dc6
docs(pds-table): add dropdown menu to responsive table story
pixelflips Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/core/src/components/pds-dropdown-menu/pds-dropdown-menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
left: var(--pine-dimension-none);
min-width: 170px;
padding: var(--pine-dimension-xs);
position: absolute;
position: fixed;
z-index: var(--pine-z-index-overlay);

:host-context([data-theme="dark"]) & {
Expand Down
1 change: 1 addition & 0 deletions libs/core/src/components/pds-dropdown-menu/pds-dropdown-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ export class PdsDropdownMenu implements BasePdsProps {
const updatePosition = () => {
computePosition(this.triggerEl, this.panelEl as HTMLElement, {
placement: this.placement,
strategy: 'fixed',
middleware: [offset(6), flip(), shift({padding: 5})],
}).then(({ x, y }) => {
Object.assign(this.panelEl.style, {
Expand Down
32 changes: 28 additions & 4 deletions libs/core/src/components/pds-table/stories/pds-table.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ const ResponsiveTemplate = (args) => html`
<pds-table-head-cell>Column Title</pds-table-head-cell>
<pds-table-head-cell>Column Title</pds-table-head-cell>
<pds-table-head-cell>Column Title</pds-table-head-cell>
<pds-table-head-cell>Column Title</pds-table-head-cell>
<pds-table-head-cell>Actions</pds-table-head-cell>
</pds-table-head>
<pds-table-body>
<pds-table-row value="responsive1">
Expand All @@ -157,7 +157,15 @@ const ResponsiveTemplate = (args) => html`
<pds-table-cell>Row Item Juliett</pds-table-cell>
<pds-table-cell>Row Item Kilo</pds-table-cell>
<pds-table-cell>Row Item Lima</pds-table-cell>
<pds-table-cell>Row Item Mike</pds-table-cell>
<pds-table-cell>
<pds-dropdown-menu placement="bottom-end">
<pds-button slot="trigger" size="sm" variant="icon-only"><pds-icon name="dot-menu-horizontal"></pds-icon></pds-button>
<pds-dropdown-menu-item>Edit</pds-dropdown-menu-item>
<pds-dropdown-menu-item>Duplicate</pds-dropdown-menu-item>
<pds-dropdown-menu-separator></pds-dropdown-menu-separator>
<pds-dropdown-menu-item destructive>Delete</pds-dropdown-menu-item>
</pds-dropdown-menu>
</pds-table-cell>
</pds-table-row>
<pds-table-row value="responsive2">
<pds-table-cell>Row Item Alpha</pds-table-cell>
Expand All @@ -171,7 +179,15 @@ const ResponsiveTemplate = (args) => html`
<pds-table-cell>Row Item Juliett</pds-table-cell>
<pds-table-cell>Row Item Kilo</pds-table-cell>
<pds-table-cell>Row Item Lima</pds-table-cell>
<pds-table-cell>Row Item Mike</pds-table-cell>
<pds-table-cell>
<pds-dropdown-menu placement="bottom-end">
<pds-button slot="trigger" size="sm" variant="icon-only"><pds-icon name="dot-menu-horizontal"></pds-icon></pds-button>
<pds-dropdown-menu-item>Edit</pds-dropdown-menu-item>
<pds-dropdown-menu-item>Duplicate</pds-dropdown-menu-item>
<pds-dropdown-menu-separator></pds-dropdown-menu-separator>
<pds-dropdown-menu-item destructive>Delete</pds-dropdown-menu-item>
</pds-dropdown-menu>
</pds-table-cell>
</pds-table-row>
<pds-table-row value="responsive3">
<pds-table-cell>Row Item Alpha</pds-table-cell>
Expand All @@ -185,7 +201,15 @@ const ResponsiveTemplate = (args) => html`
<pds-table-cell>Row Item Juliett</pds-table-cell>
<pds-table-cell>Row Item Kilo</pds-table-cell>
<pds-table-cell>Row Item Lima</pds-table-cell>
<pds-table-cell>Row Item Mike</pds-table-cell>
<pds-table-cell>
<pds-dropdown-menu placement="bottom-end">
<pds-button slot="trigger" size="sm" variant="icon-only"><pds-icon name="dot-menu-horizontal"></pds-icon></pds-button>
<pds-dropdown-menu-item>Edit</pds-dropdown-menu-item>
<pds-dropdown-menu-item>Duplicate</pds-dropdown-menu-item>
<pds-dropdown-menu-separator></pds-dropdown-menu-separator>
<pds-dropdown-menu-item destructive>Delete</pds-dropdown-menu-item>
</pds-dropdown-menu>
</pds-table-cell>
</pds-table-row>
</pds-table-body>
</pds-table>`;
Expand Down
Loading