Skip to content

Conversation

@pixelflips
Copy link
Member

Description

Fixes an issue where pds-dropdown-menu gets clipped when placed inside containers with overflow: hidden (e.g., responsive pds-table).

The fix uses Floating UI's strategy: 'fixed' option instead of the default 'absolute' positioning, which allows the dropdown panel to "break out" of clipping ancestors.

Fixes DSS-89

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • unit tests
  • tested manually

Manual Testing:

  • Verified dropdown appears correctly in responsive tables (no clipping)
  • Verified dropdown still works in normal contexts
  • Verified ::part(menu-panel) styling still works
  • Verified keyboard navigation still functions

Test Configuration:

  • Pine versions: 3.14.0
  • OS: macOS
  • Browsers: Chrome

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass locally with my changes

@pixelflips pixelflips self-assigned this Jan 23, 2026
@netlify
Copy link

netlify bot commented Jan 23, 2026

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit 2625dc6
🔍 Latest deploy log https://app.netlify.com/projects/pine-design-system/deploys/6973b6697566db00087f8698
😎 Deploy Preview https://deploy-preview-643--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added bug Something isn't working package: core Changes have been made to the Core package labels Jan 23, 2026
@pixelflips pixelflips marked this pull request as ready for review January 23, 2026 18:02
@pixelflips pixelflips merged commit dfd726c into main Jan 23, 2026
15 checks passed
@pixelflips pixelflips deleted the fix/dropdown-overflow branch January 23, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working package: core Changes have been made to the Core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants