Skip to content

fix(pds-alert): update padding of alert to 20px #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pixelflips merged 2 commits into from
Dec 5, 2025
Merged

fix(pds-alert): update padding of alert to 20px #602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dbc771
fix(pds-alert): update padding of alert to 20px
pixelflips Dec 4, 2025
bf95aa7
test(pds-alert): remove unnecessary padding attribute
pixelflips Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions libs/core/src/components/pds-alert/pds-alert.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
--pds-alert-color-text: var(--pine-alert-color-text);
--pds-alert-color-dismiss: var(--pine-alert-color-dismiss);
--pds-alert-background-dismiss-hover: var(--pine-alert-color-dismiss-hover);

padding: var(--pine-dimension-250);
}

.pds-alert__container--danger {
Expand Down
1 change: 0 additions & 1 deletion libs/core/src/components/pds-alert/pds-alert.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ export class PdsAlert {
border-radius="md"
border
display="block"
padding="md"
>
<pds-box gap="sm" display="flex">
<pds-icon
Expand Down
10 changes: 5 additions & 5 deletions libs/core/src/components/pds-alert/test/pds-alert.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ describe('pds-alert', () => {
expect(page.root).toEqualHtml(`
<pds-alert class="pds-alert" variant="default">
<mock:shadow-root>
<pds-box class="pds-alert__container pds-alert__container--default" background-color="var(--pds-alert-background)" border="" border-color="var(--pds-alert-border-color)" border-radius="md" display="block" padding="md">
<pds-box class="pds-alert__container pds-alert__container--default" background-color="var(--pds-alert-background)" border="" border-color="var(--pds-alert-border-color)" border-radius="md" display="block">
<pds-box display="flex" gap="sm">
<pds-icon class="pds-alert__icon" color="var(--pds-alert-color-icon)" icon="info-circle-filled" size="var(--pds-alert-icon-size)"></pds-icon>
<pds-box class="pds-alert__content-wrapper" direction="column" flex="grow" gap="xs">
Expand All @@ -35,7 +35,7 @@ describe('pds-alert', () => {
expect(page.root).toEqualHtml(`
<pds-alert class="pds-alert" heading="Test Alert Heading" variant="default">
<mock:shadow-root>
<pds-box class="pds-alert__container pds-alert__container--default" background-color="var(--pds-alert-background)" border="" border-color="var(--pds-alert-border-color)" border-radius="md" display="block" padding="md">
<pds-box class="pds-alert__container pds-alert__container--default" background-color="var(--pds-alert-background)" border="" border-color="var(--pds-alert-border-color)" border-radius="md" display="block">
<pds-box display="flex" gap="sm">
<pds-icon class="pds-alert__icon" color="var(--pds-alert-color-icon)" icon="info-circle-filled" size="var(--pds-alert-icon-size)"></pds-icon>
<pds-box class="pds-alert__content-wrapper" direction="column" flex="grow" gap="xs">
Expand All @@ -61,7 +61,7 @@ describe('pds-alert', () => {
expect(page.root).toEqualHtml(`
<pds-alert class="pds-alert" variant="default">
<mock:shadow-root>
<pds-box class="pds-alert__container pds-alert__container--default" background-color="var(--pds-alert-background)" border="" border-color="var(--pds-alert-border-color)" border-radius="md" display="block" padding="md">
<pds-box class="pds-alert__container pds-alert__container--default" background-color="var(--pds-alert-background)" border="" border-color="var(--pds-alert-border-color)" border-radius="md" display="block">
<pds-box display="flex" gap="sm">
<pds-icon class="pds-alert__icon" color="var(--pds-alert-color-icon)" icon="info-circle-filled" size="var(--pds-alert-icon-size)"></pds-icon>
<pds-box class="pds-alert__content-wrapper" direction="column" flex="grow" gap="xs">
Expand All @@ -87,7 +87,7 @@ describe('pds-alert', () => {
expect(page.root).toEqualHtml(`
<pds-alert class="pds-alert" heading="This heading should not show" small="true" variant="default">
<mock:shadow-root>
<pds-box class="pds-alert__container pds-alert__container--default" background-color="var(--pds-alert-background)" border="" border-color="var(--pds-alert-border-color)" border-radius="md" display="block" padding="md">
<pds-box class="pds-alert__container pds-alert__container--default" background-color="var(--pds-alert-background)" border="" border-color="var(--pds-alert-border-color)" border-radius="md" display="block">
<pds-box display="flex" gap="sm">
<pds-icon class="pds-alert__icon pds-alert__icon--small" color="var(--pds-alert-color-icon)" icon="info-circle-filled" size="var(--pds-alert-icon-size)"></pds-icon>
<pds-box class="pds-alert__content-wrapper" direction="column" flex="grow" gap="xs">
Expand All @@ -113,7 +113,7 @@ describe('pds-alert', () => {
expect(page.root).toEqualHtml(`
<pds-alert class="pds-alert" dismissible="true" variant="default">
<mock:shadow-root>
<pds-box class="pds-alert__container pds-alert__container--default" background-color="var(--pds-alert-background)" border="" border-color="var(--pds-alert-border-color)" border-radius="md" display="block" padding="md">
<pds-box class="pds-alert__container pds-alert__container--default" background-color="var(--pds-alert-background)" border="" border-color="var(--pds-alert-border-color)" border-radius="md" display="block">
<pds-box display="flex" gap="sm">
<pds-icon class="pds-alert__icon" color="var(--pds-alert-color-icon)" icon="info-circle-filled" size="var(--pds-alert-icon-size)"></pds-icon>
<pds-box class="pds-alert__content-wrapper" direction="column" flex="grow" gap="xs">
Expand Down
Loading