Skip to content

Conversation

@pixelflips
Copy link
Member

@pixelflips pixelflips commented Dec 4, 2025

Description

This PR updates the pds-alert component to use a direct CSS token for padding instead of relying on the pds-box padding prop. The padding is now set to --pine-dimension-250 (20px) directly in the component's stylesheet, ensuring consistent padding across all alert variants.

Changes:

  • Removed padding="md" prop from the pds-box wrapper in pds-alert.tsx
  • Added padding: var(--pine-dimension-250) directly to .pds-alert__container in pds-alert.scss

This change improves maintainability by using design tokens directly and removes the dependency on the pds-box component's padding prop, making the styling more explicit and easier to maintain.

No new dependencies or updates are required for this change.

Fixes DSS-28

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests you've added and run to verify your changes.

Provide instructions so that we can reproduce.

Please also list any relevant details for your test configuration.

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Test Configuration:

  • Pine versions: Latest
  • OS: macOS
  • Browsers: Chrome, Safari, Firefox
  • Screen readers: N/A
  • Misc: Verified alert padding visually matches design specifications (20px)

Manual Testing:

  • Verified all alert variants (danger, info, success, warning) display with correct 20px padding
  • Confirmed alert content, icons, and dismiss buttons are properly positioned
  • Tested with and without dismiss functionality
  • Verified responsive behavior remains unchanged

Checklist:

If not applicable, leave options unchecked.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@pixelflips pixelflips self-assigned this Dec 4, 2025
@github-actions github-actions bot added bug Something isn't working package: core Changes have been made to the Core package labels Dec 4, 2025
@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit bf95aa7
🔍 Latest deploy log https://app.netlify.com/projects/pine-design-system/deploys/6932135c7d2d110008c72ba4
😎 Deploy Preview https://deploy-preview-602--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pixelflips pixelflips marked this pull request as ready for review December 4, 2025 23:10
@pixelflips
Copy link
Member Author

@amylu555 you can use the preview link in the netlify comment above to confirm the padding update.

Copy link

@amylu555 amylu555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@pixelflips pixelflips merged commit 7214d8a into main Dec 5, 2025
17 checks passed
@pixelflips pixelflips deleted the fix/alert-padding branch December 5, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working package: core Changes have been made to the Core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants