fix(pds-alert): update padding of alert to 20px #602
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
pds-alertcomponent to use a direct CSS token for padding instead of relying on thepds-boxpadding prop. The padding is now set to--pine-dimension-250(20px) directly in the component's stylesheet, ensuring consistent padding across all alert variants.Changes:
padding="md"prop from thepds-boxwrapper inpds-alert.tsxpadding: var(--pine-dimension-250)directly to.pds-alert__containerinpds-alert.scssThis change improves maintainability by using design tokens directly and removes the dependency on the
pds-boxcomponent's padding prop, making the styling more explicit and easier to maintain.No new dependencies or updates are required for this change.
Fixes DSS-28
Type of change
How Has This Been Tested?
Please describe the tests you've added and run to verify your changes.
Provide instructions so that we can reproduce.
Please also list any relevant details for your test configuration.
Test Configuration:
Manual Testing:
Checklist:
If not applicable, leave options unchecked.