Skip to content

[Fix]: Shader linker info log will now display correctly #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Fix]: Shader linker info log will now display correctly #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb6e42b
fix: linker error will now display correctly
andersblomqvist Nov 11, 2024
6565d02
fix: in case log is 0, dont try access it
andersblomqvist Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 22 additions & 12 deletions libs/gl_utils/computeshader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,22 +46,32 @@ namespace gl
}

glLinkProgram(shader_program);
glValidateProgram(shader_program);

gl::ExitOnGLError("gl::ComputeShader >> Unable to link shaders.");

// Check link status
int rvalue;
glGetProgramiv(shader_program, GL_LINK_STATUS, &rvalue);
if (!rvalue) {
fprintf(stderr, "Error in linking compute shader program\n");
GLchar log[10240];
GLsizei length;
glGetProgramInfoLog(shader_program, 10239, &length, log);
fprintf(stderr, "Linker log:\n%s\n", log);
exit(41);
int is_linked;
glGetProgramiv(shader_program, GL_LINK_STATUS, &is_linked);
if (!is_linked) {
GLint max_length = 0;
glGetProgramiv(shader_program, GL_INFO_LOG_LENGTH, &max_length);

if (max_length != 0) {
std::vector<GLchar> info_log(max_length);
glGetProgramInfoLog(shader_program, max_length, &max_length, &info_log[0]);
std::string info_log_str(info_log.begin(), info_log.end());
std::cout << info_log_str << std::endl;
}
else {
std::cout << "No info log from linking compute shader program" << std::endl;
}

fprintf(stderr, "Error in linking compute shader program\n");
exit(41);
}

gl::ExitOnGLError("gl::ComputeShader >> Unable to link shaders.");

glValidateProgram(shader_program);

gl::ExitOnGLError("gl::ComputeShader >> Unable to load and link shaders.");

return true;
Expand Down