-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3.12 support #1281
python3.12 support #1281
Conversation
requirements.txt
Outdated
@@ -1,6 +1,6 @@ | |||
lxml>=3.2.4 | |||
# ncclient version 0.6.10 has issues with PyEZ(junos-eznc) and needs to be avoided | |||
ncclient==0.6.13 | |||
ncclient==0.6.15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we really should make this a ncclient>=0.6.15
(to try avoid pinning to a specific version of ncclient).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ktbyers
Thanks vey much for the review comments .
I will update the fix .
Thanks
We should update this (so newer versions of Python have some testing in the CI/CD system): https://github.com/Juniper/py-junos-eznc/blob/master/.github/workflows/pylint.yml#L17 @chidanandpujar Do you want to add that into this PR? |
Hi @ktbyers Thanks |
Python3.12 support
#1253
#1252
#1280
#1276