Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.12 support #1281

Closed

Conversation

chidanandpujar
Copy link
Collaborator

@chidanandpujar chidanandpujar commented Nov 6, 2023

Python3.12 support
#1253
#1252
#1280
#1276

requirements.txt Outdated
@@ -1,6 +1,6 @@
lxml>=3.2.4
# ncclient version 0.6.10 has issues with PyEZ(junos-eznc) and needs to be avoided
ncclient==0.6.13
ncclient==0.6.15
Copy link

@ktbyers ktbyers Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we really should make this a ncclient>=0.6.15 (to try avoid pinning to a specific version of ncclient).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ktbyers
Thanks vey much for the review comments .
I will update the fix .

Thanks

@ktbyers
Copy link

ktbyers commented Nov 17, 2023

We should update this (so newer versions of Python have some testing in the CI/CD system):

https://github.com/Juniper/py-junos-eznc/blob/master/.github/workflows/pylint.yml#L17

@chidanandpujar Do you want to add that into this PR?

@chidanandpujar
Copy link
Collaborator Author

chidanandpujar commented Nov 17, 2023

We should update this (so newer versions of Python have some testing in the CI/CD system):

https://github.com/Juniper/py-junos-eznc/blob/master/.github/workflows/pylint.yml#L17

@chidanandpujar Do you want to add that into this PR?

Hi @ktbyers
Thanks for the review comments .
We will update the github workflow with never versions of python.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants