Bump ncclient to 0.6.15 to support Python 3.12 #1277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hi @ljarasius Thanks |
ktbyers
reviewed
Nov 15, 2023
| @@ -1,6 +1,6 @@ | |||
| lxml>=3.2.4 | |||
| # ncclient version 0.6.10 has issues with PyEZ(junos-eznc) and needs to be avoided | |||
| ncclient==0.6.13 | |||
| ncclient==0.6.15 | |||
There was a problem hiding this comment.
I think we should make this ncclient>=0.6.15 (to avoid pinning to one specific ncclient release)
|
Duplicate with #1281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
ncclient 0.6.13 does not build successfully on Python 3.12, and as PyEz has this dependency pinned to this version it results in PyEz also failing to be installed successfully.
ncclient/ncclient#572
Bumped the pinned version to 0.6.15 to resolve this issue, however in favour of updating to have the minimum version be set to 0.6.13 instead if this is preferable.
Let me know if you have any questions.
Kind regards,
Louis