Add tests for StatsAPI modeling functions #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that we don't accidentally stop exporting some functions and that fallbacks defined in StatsAPI work. Stop importing `params` and `params!` as they are neither used nor reexported
bkamins
approved these changes
Feb 19, 2022
bkamins
reviewed
Feb 19, 2022
| cor, corm, cov2cor!, unscaled_covzm, quantile, sqrt!, | ||
| median, middle | ||
| using StatsAPI: StatisticalModel, RegressionModel | ||
| import StatsAPI: pairwise, pairwise!, params, params!, |
There was a problem hiding this comment.
It's not actually (and has never been) reexported, so if we tested something it would be that it's not defined. :-)
There was a problem hiding this comment.
Woops, actually the fact that we don't export it doesn't mean it's fine to stop importing it. Packages probably rely on StatsBase defining it. It was added by #274. I've added a commit to fix this.
bkamins
approved these changes
Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that we don't accidentally stop exporting some functions and that
fallbacks defined in StatsAPI work.
Stop importing
paramsandparams!as they are neither used nor reexported