Skip to content

Conversation

nalimilan
Copy link
Member

@nalimilan nalimilan commented Feb 16, 2022

Cover functions for which we provide a fallback definition.
Also turn ExceptionError into more specific ArgumentError.

Maybe it would also be worth testing that other functions (for which we only provide an empty definition) are defined?

Cover functions for which we provide a fallback definition.
Also turn `ExceptionError` into more specific `ArgumentError`.
@nalimilan nalimilan merged commit 6680786 into main Feb 19, 2022
@nalimilan nalimilan deleted the nl/tests branch February 19, 2022 16:43
@nalimilan
Copy link
Member Author

Thanks. Next step at JuliaStats/StatsBase.jl#767.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants