add a helpful perm warning to 403 errors #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that JuliaRegistries/TagBotErrorReports#101 (comment) was fixed by updating the perms vchuravy/HashArrayMappedTries.jl@39c45bc |
|
Bump @christopher-dG Let me know if I should just proceed with things like this |
ericphanson
reviewed
Sep 7, 2023
IanButterworth
commented
Sep 10, 2023
ericphanson
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the only 3 error reports of
Resource not accessible by integrationsince #264 they all were missing the new permissions.So this tries to give more targeted feedback to the user, without erroring.
If 403's turn out to be only tied to bad perms now perhaps this could be changed to a disallowed error and actually throw on the action. But that's premature.