Skip to content

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Jul 24, 2023

Fixes #263
Fixes #258
Fixes #262

Not sure how to test this before merge given tests didn't fail while this was broken.

@DilumAluthge DilumAluthge requested review from christopher-dG and removed request for christopher-dG July 24, 2023 03:17
@IanButterworth IanButterworth force-pushed the ib/general_branch_fix branch from 1d790de to 655bb41 Compare July 24, 2023 03:52
@IanButterworth IanButterworth changed the title update for newer Genreral branch format update for newer General branch format Jul 24, 2023
@IanButterworth IanButterworth force-pushed the ib/general_branch_fix branch 3 times, most recently from e0f0acd to e8d1ef7 Compare July 24, 2023 04:12
@IanButterworth
Copy link
Member Author

@christopher-dG are you the right person to ping on this? If not who'd be good?

@IanButterworth
Copy link
Member Author

Bump

@IanButterworth IanButterworth force-pushed the ib/general_branch_fix branch 10 times, most recently from 764ca4f to 3507e83 Compare August 23, 2023 03:19
Copy link
Member

@christopher-dG christopher-dG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks, looks good 👍

Copy link
Member

@christopher-dG christopher-dG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Can you bump the patch version in pyproject.toml?

@christopher-dG christopher-dG merged commit 6dc4354 into JuliaRegistries:master Aug 25, 2023
@IanButterworth
Copy link
Member Author

IanButterworth commented Aug 25, 2023

It'd be good to test this in the wild. Does the bot pick up new releases immediately?

@IanButterworth IanButterworth deleted the ib/general_branch_fix branch August 25, 2023 13:12
@christopher-dG
Copy link
Member

I actually realized that I should not have asked you to bump the version yourself, since the release script does that automatically. Oops! I'll revert just that change then run the release workflow.

@IanButterworth
Copy link
Member Author

Sounds good. Worth getting any other dep bump PRs in while we're here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release notes are ignored Could not find registry PR Error after "Warning: No registry pull request was found for this version"

3 participants